From 784ee36121289f25b0b292c26cd8ccf0faeb124b Mon Sep 17 00:00:00 2001 From: Chris Hennes Date: Mon, 1 Mar 2021 09:19:20 -0600 Subject: [PATCH] [Draft] Eliminate unused loop iteration variables When creating arrays of colors, the color information is often created to be the same length as some array of objects. In three instances this was achieved with a loop over that list of objects, even though the objects themselves are never used. This commit eliminates those loops and creates the required number of color instances directly. Identified by LGTM. --- src/Mod/Draft/draftviewproviders/view_array.py | 3 +-- src/Mod/Draft/draftviewproviders/view_clone.py | 7 ++----- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/Mod/Draft/draftviewproviders/view_array.py b/src/Mod/Draft/draftviewproviders/view_array.py index c930768628..e73f6b6528 100644 --- a/src/Mod/Draft/draftviewproviders/view_array.py +++ b/src/Mod/Draft/draftviewproviders/view_array.py @@ -60,8 +60,7 @@ class ViewProviderDraftArray(ViewProviderDraft): else: c = vobj.Object.Base.ViewObject.ShapeColor c = (c[0],c[1],c[2],vobj.Object.Base.ViewObject.Transparency/100.0) - for f in vobj.Object.Base.Shape.Faces: - colors.append(c) + colors += [c] * len(vobj.Object.Base.Shape.Faces) if colors: n = 1 if hasattr(vobj.Object,"ArrayType"): diff --git a/src/Mod/Draft/draftviewproviders/view_clone.py b/src/Mod/Draft/draftviewproviders/view_clone.py index 0871309128..5b0c1ecaf7 100644 --- a/src/Mod/Draft/draftviewproviders/view_clone.py +++ b/src/Mod/Draft/draftviewproviders/view_clone.py @@ -61,9 +61,7 @@ class ViewProviderClone: else: c = o.ViewObject.ShapeColor c = (c[0],c[1],c[2],o.ViewObject.Transparency/100.0) - for f in o.Shape.Faces: # TODO: verify this line - colors.append(c) - + colors += [c] * len(o.Shape.Faces) # TODO: verify this line elif o.hasExtension("App::GeoFeatureGroupExtension"): for so in vobj.Object.Group: if so.isDerivedFrom("Part::Feature"): @@ -72,8 +70,7 @@ class ViewProviderClone: else: c = so.ViewObject.ShapeColor c = (c[0],c[1],c[2],so.ViewObject.Transparency/100.0) - for f in so.Shape.Faces: - colors.append(c) + colors += [c] * len(so.Shape.Faces) if colors: vobj.DiffuseColor = colors