From 79422471437aa64a7ab3817ae87cfb62d6cc46ed Mon Sep 17 00:00:00 2001 From: wandererfan Date: Thu, 27 Nov 2025 16:55:26 -0500 Subject: [PATCH] [TD]remove obsolete preference --- .../TechDraw/Gui/DlgPrefsTechDrawGeneral.ui | 23 +------------------ .../Gui/DlgPrefsTechDrawGeneralImp.cpp | 2 -- .../TechDraw/Gui/ViewProviderDrawingView.cpp | 12 ++++------ 3 files changed, 5 insertions(+), 32 deletions(-) diff --git a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneral.ui b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneral.ui index 8ac2fc573e..2bd622980a 100644 --- a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneral.ui +++ b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneral.ui @@ -7,7 +7,7 @@ 0 0 676 - 1200 + 1302 @@ -845,27 +845,6 @@ for ProjectionGroups - - - - - true - - - - Displays view labels even when frames are suppressed - - - Always Show Label - - - AlwaysShowLabel - - - /Mod/TechDraw/General - - - diff --git a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneralImp.cpp b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneralImp.cpp index a734f6a4db..33235beb35 100644 --- a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneralImp.cpp +++ b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneralImp.cpp @@ -82,7 +82,6 @@ void DlgPrefsTechDrawGeneralImp::saveSettings() ui->cb_viewFramesVisibility->onSave(); ui->cb_useCameraDirection->onSave(); - ui->cb_alwaysShowLabel->onSave(); ui->cb_SnapViews->onSave(); ui->psb_SnapFactor->onSave(); ui->cb_SnapHighlights->onSave(); @@ -131,7 +130,6 @@ void DlgPrefsTechDrawGeneralImp::loadSettings() ui->cb_viewFramesVisibility->onRestore(); ui->cb_useCameraDirection->onRestore(); - ui->cb_alwaysShowLabel->onRestore(); ui->cb_SnapViews->onRestore(); ui->psb_SnapFactor->onRestore(); diff --git a/src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp b/src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp index 8cee4e87d2..53a944ed73 100644 --- a/src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp +++ b/src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp @@ -65,6 +65,7 @@ ViewProviderDrawingView::ViewProviderDrawingView() : static const char *group = "Base"; auto showLabel = Preferences::alwaysShowLabel(); + // TODO: KeepLabel is not used. Make it ReadOnly or Hidden? ADD_PROPERTY_TYPE(KeepLabel ,(showLabel), group, App::Prop_None, "Keep Label on Page even if toggled off"); ADD_PROPERTY_TYPE(StackOrder,(0),group,App::Prop_None,"Over or under lap relative to other views"); @@ -111,14 +112,9 @@ void ViewProviderDrawingView::onChanged(const App::Property *prop) return; } - if (prop == &Visibility) { - //handled by ViewProviderDocumentObject - } else if (prop == &KeepLabel) { - QGIView* qgiv = getQView(); - if (qgiv) { - qgiv->updateView(true); - } - } + // if (prop == &Visibility) { + // //handled by ViewProviderDocumentObject + // } if (prop == &StackOrder) { QGIView* qgiv = getQView();