From 79bb68ef142f9273753954fd356ec00f3a64a2af Mon Sep 17 00:00:00 2001
From: Paddle <PaddleStroke@users.noreply.github.com>
Date: Sat, 26 Aug 2023 19:55:17 +0200
Subject: [PATCH] Sketcher settings Dimension Add enums instead of magic
 numbers

---
 src/Mod/Sketcher/Gui/SketcherSettings.cpp | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/src/Mod/Sketcher/Gui/SketcherSettings.cpp b/src/Mod/Sketcher/Gui/SketcherSettings.cpp
index 37678cac96..17b4deb15f 100644
--- a/src/Mod/Sketcher/Gui/SketcherSettings.cpp
+++ b/src/Mod/Sketcher/Gui/SketcherSettings.cpp
@@ -67,17 +67,23 @@ void SketcherSettings::saveSettings()
     ui->checkBoxNotifyConstraintSubstitutions->onSave();
     ui->checkBoxAutoRemoveRedundants->onSave();
 
+    enum {
+        DimensionSingleTool,
+        DimensionSeparateTools,
+        DimensionBoth
+    };
+
     // Dimensioning constraints mode
     ParameterGrp::handle hGrp = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/Mod/Sketcher/dimensioning");
     bool singleTool = true;
     bool SeparatedTools = false;
     int index = ui->dimensioningMode->currentIndex();
     switch (index) {
-    case 1:
+    case DimensionSeparateTools:
         singleTool = false;
         SeparatedTools = true;
         break;
-    case 2:
+    case DimensionBoth:
         singleTool = true;
         SeparatedTools = true;
         break;
@@ -87,15 +93,21 @@ void SketcherSettings::saveSettings()
 
     ui->radiusDiameterMode->setEnabled(index != 1);
 
+    enum {
+        DimensionAutoRadiusDiam,
+        DimensionDiameter,
+        DimensionRadius
+    };
+
     bool Diameter = true;
     bool Radius = true;
     index = ui->radiusDiameterMode->currentIndex();
     switch (index) {
-    case 1:
+    case DimensionDiameter:
         Diameter = true;
         Radius = false;
         break;
-    case 2:
+    case DimensionRadius:
         Diameter = false;
         Radius = true;
         break;