From 79d4c1556f0a3f23a69ca8c01ff3ed7b1a1a05be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjamin=20Br=C3=A6strup=20Sayoc?= <benj5378@outlook.com>
Date: Sun, 17 Jul 2022 19:32:35 +0200
Subject: [PATCH]  [TechDraw] Improve readability of DrawWeldSymbol.cpp

---
 src/Mod/TechDraw/App/DrawWeldSymbol.cpp | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/src/Mod/TechDraw/App/DrawWeldSymbol.cpp b/src/Mod/TechDraw/App/DrawWeldSymbol.cpp
index 9725e73544..01e8bef4a4 100644
--- a/src/Mod/TechDraw/App/DrawWeldSymbol.cpp
+++ b/src/Mod/TechDraw/App/DrawWeldSymbol.cpp
@@ -108,9 +108,6 @@ void DrawWeldSymbol::onSettingDocument()
 
 void DrawWeldSymbol::onChanged(const App::Property* prop)
 {
-    if (!isRestoring()) {
-        //nothing in particular
-    }
     DrawView::onChanged(prop);
 }
 
@@ -135,13 +132,15 @@ std::vector<DrawTileWeld*> DrawWeldSymbol::getTiles(void) const
     std::vector<DrawTileWeld*> result;
 
     std::vector<App::DocumentObject*> tiles = getInList();
-    if (!tiles.empty()) {
-        for(std::vector<App::DocumentObject *>::iterator it = tiles.begin(); it != tiles.end(); it++) {
-            if ((*it)->getTypeId().isDerivedFrom(TechDraw::DrawTileWeld::getClassTypeId())) {
-                App::DocumentObject* doTemp = (*it);
-                DrawTileWeld* temp = static_cast<DrawTileWeld*>(doTemp);
-                result.push_back(temp);
-            }
+    if (tiles.empty()) {
+        return result;
+    }
+
+    for(std::vector<App::DocumentObject *>::iterator it = tiles.begin(); it != tiles.end(); it++) {
+        if ((*it)->getTypeId().isDerivedFrom(TechDraw::DrawTileWeld::getClassTypeId())) {
+            App::DocumentObject* doTemp = (*it);
+            DrawTileWeld* temp = static_cast<DrawTileWeld*>(doTemp);
+            result.push_back(temp);
         }
     }
     return result;
@@ -149,17 +148,16 @@ std::vector<DrawTileWeld*> DrawWeldSymbol::getTiles(void) const
 
 bool DrawWeldSymbol::isTailRightSide()
 {
-    bool result = true;
     App::DocumentObject* obj = Leader.getValue();
     TechDraw::DrawLeaderLine* realLeader = dynamic_cast<TechDraw::DrawLeaderLine*>(obj);
     if (realLeader) {
         Base::Vector3d tail = realLeader->getTailPoint();
         Base::Vector3d kink = realLeader->getKinkPoint();
         if (tail.x < kink.x)  {   //tail is to left
-            result = false;
+            return false;
         }
     }
-    return result;
+    return true;
 }