From 7a266b1d7822951cfed759d94df3f3ffe4369812 Mon Sep 17 00:00:00 2001 From: Ladislav Michl Date: Sat, 27 Sep 2025 12:23:03 +0200 Subject: [PATCH] PartDesign: Microoptimize updateSpacings() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This also fixes "comparison of integer expressions of different signedness: ‘int’ and ‘size_t’" warning. Fixes: 5d2037c82058 ("PartDesign: Transform rework") --- src/Mod/PartDesign/App/FeatureLinearPattern.cpp | 4 ++-- src/Mod/PartDesign/App/FeaturePolarPattern.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Mod/PartDesign/App/FeatureLinearPattern.cpp b/src/Mod/PartDesign/App/FeatureLinearPattern.cpp index 7a0aaaf318..a2faf08082 100644 --- a/src/Mod/PartDesign/App/FeatureLinearPattern.cpp +++ b/src/Mod/PartDesign/App/FeatureLinearPattern.cpp @@ -464,13 +464,13 @@ void LinearPattern::updateSpacings(LinearPatternDirection dir) if (spacings.size() == targetCount) { return; } - else if (spacings.size() < targetCount) { + if (spacings.size() < targetCount) { spacings.reserve(targetCount); while (spacings.size() < targetCount) { spacings.push_back(-1.0); } } - else if ((int)spacings.size() > targetCount) { + else { spacings.resize(targetCount); } diff --git a/src/Mod/PartDesign/App/FeaturePolarPattern.cpp b/src/Mod/PartDesign/App/FeaturePolarPattern.cpp index 79077a09e1..6198eadb3e 100644 --- a/src/Mod/PartDesign/App/FeaturePolarPattern.cpp +++ b/src/Mod/PartDesign/App/FeaturePolarPattern.cpp @@ -320,13 +320,13 @@ void PolarPattern::updateSpacings() if (spacings.size() == targetCount) { return; } - else if (spacings.size() < targetCount) { + if (spacings.size() < targetCount) { spacings.reserve(targetCount); while (spacings.size() < targetCount) { spacings.push_back(-1.0); } } - else if ((int)spacings.size() > targetCount) { + else { spacings.resize(targetCount); }