kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Mesh: Fix linter warnings

Browse Source
This commit is contained in:
wmayer
2024-11-20 23:02:40 +01:00
committed by wwmayer
parent 4e82a0af48
commit 7a2bfb7370
86 changed files with 1734 additions and 1882 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Mod/Mesh/App/FeatureMeshSegmentByMesh.cpp
View File

@@ -71,7 +71,7 @@ App::DocumentObjectExecReturn* SegmentByMesh::execute()
if (!kernel) {
return new App::DocumentObjectExecReturn("No mesh specified.\n");
}
else if (mesh->isError()) {
if (mesh->isError()) {
return new App::DocumentObjectExecReturn("No valid mesh.\n");
}
@@ -86,7 +86,7 @@ App::DocumentObjectExecReturn* SegmentByMesh::execute()
if (!toolmesh) {
return new App::DocumentObjectExecReturn("No toolmesh specified.\n");
}
else if (tool->isError()) {
if (tool->isError()) {
return new App::DocumentObjectExecReturn("No valid toolmesh.\n");
}
@@ -105,18 +105,17 @@ App::DocumentObjectExecReturn* SegmentByMesh::execute()
}
std::vector<MeshCore::FacetIndex> faces;
std::vector<MeshGeomFacet> aFaces;
MeshAlgorithm cAlg(rMeshKernel);
if (cNormal.Length() > 0.1f) { // not a null vector
if (cNormal.Length() > 0.1F) { // not a null vector
cAlg.GetFacetsFromToolMesh(rToolMesh, cNormal, faces);
}
else {
cAlg.GetFacetsFromToolMesh(rToolMesh, Base::Vector3f(0.0, 1.0f, 0.0f), faces);
cAlg.GetFacetsFromToolMesh(rToolMesh, Base::Vector3f(0.0, 1.0F, 0.0F), faces);
}
// if the clipping plane was set then we want only the visible facets
if (cNormal.Length() > 0.1f) { // not a null vector
if (cNormal.Length() > 0.1F) { // not a null vector
// now we have too many facets since we have (invisible) facets near to the back clipping
// plane, so we need the nearest facet to the front clipping plane
//
@@ -149,6 +148,8 @@ App::DocumentObjectExecReturn* SegmentByMesh::execute()
}
}
std::vector<MeshGeomFacet> aFaces;
aFaces.reserve(faces.size());
for (MeshCore::FacetIndex it : faces) {
aFaces.push_back(rMeshKernel.GetFacet(it));
}