kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Mesh: Fix linter warnings

Browse Source
This commit is contained in:
wmayer
2024-11-20 23:02:40 +01:00
committed by wwmayer
parent 4e82a0af48
commit 7a2bfb7370
86 changed files with 1734 additions and 1882 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
src/Mod/Mesh/App/FeatureMeshSolid.cpp
View File

@@ -58,14 +58,13 @@ App::DocumentObjectExecReturn* Sphere::execute()
{
std::unique_ptr<MeshObject> mesh(
MeshObject::createSphere((float)Radius.getValue(), Sampling.getValue()));
if (mesh.get()) {
if (mesh) {
mesh->setPlacement(this->Placement.getValue());
Mesh.setValue(mesh->getKernel());
return App::DocumentObject::StdReturn;
}
else {
return new App::DocumentObjectExecReturn("Cannot create sphere", this);
}
return new App::DocumentObjectExecReturn("Cannot create sphere", this);
}
void Sphere::handleChangedPropertyType(Base::XMLReader& reader,
@@ -109,14 +108,13 @@ App::DocumentObjectExecReturn* Ellipsoid::execute()
std::unique_ptr<MeshObject> mesh(MeshObject::createEllipsoid((float)Radius1.getValue(),
(float)Radius2.getValue(),
Sampling.getValue()));
if (mesh.get()) {
if (mesh) {
mesh->setPlacement(this->Placement.getValue());
Mesh.setValue(mesh->getKernel());
return App::DocumentObject::StdReturn;
}
else {
return new App::DocumentObjectExecReturn("Cannot create ellipsoid", this);
}
return new App::DocumentObjectExecReturn("Cannot create ellipsoid", this);
}
void Ellipsoid::handleChangedPropertyType(Base::XMLReader& reader,
@@ -167,14 +165,13 @@ App::DocumentObjectExecReturn* Cylinder::execute()
Closed.getValue(),
(float)EdgeLength.getValue(),
Sampling.getValue()));
if (mesh.get()) {
if (mesh) {
mesh->setPlacement(this->Placement.getValue());
Mesh.setValue(mesh->getKernel());
return App::DocumentObject::StdReturn;
}
else {
return new App::DocumentObjectExecReturn("Cannot create cylinder", this);
}
return new App::DocumentObjectExecReturn("Cannot create cylinder", this);
}
void Cylinder::handleChangedPropertyType(Base::XMLReader& reader,
@@ -228,14 +225,13 @@ App::DocumentObjectExecReturn* Cone::execute()
Closed.getValue(),
(float)EdgeLength.getValue(),
Sampling.getValue()));
if (mesh.get()) {
if (mesh) {
mesh->setPlacement(this->Placement.getValue());
Mesh.setValue(mesh->getKernel());
return App::DocumentObject::StdReturn;
}
else {
return new App::DocumentObjectExecReturn("Cannot create cone", this);
}
return new App::DocumentObjectExecReturn("Cannot create cone", this);
}
void Cone::handleChangedPropertyType(Base::XMLReader& reader,
@@ -280,14 +276,13 @@ App::DocumentObjectExecReturn* Torus::execute()
std::unique_ptr<MeshObject> mesh(MeshObject::createTorus((float)Radius1.getValue(),
(float)Radius2.getValue(),
Sampling.getValue()));
if (mesh.get()) {
if (mesh) {
mesh->setPlacement(this->Placement.getValue());
Mesh.setValue(mesh->getKernel());
return App::DocumentObject::StdReturn;
}
else {
return new App::DocumentObjectExecReturn("Cannot create torus", this);
}
return new App::DocumentObjectExecReturn("Cannot create torus", this);
}
void Torus::handleChangedPropertyType(Base::XMLReader& reader,
@@ -311,9 +306,9 @@ PROPERTY_SOURCE(Mesh::Cube, Mesh::Feature)
Cube::Cube()
{
ADD_PROPERTY_TYPE(Length, (10.0f), "Cube", App::Prop_None, "The length of the cube");
ADD_PROPERTY_TYPE(Width, (10.0f), "Cube", App::Prop_None, "The width of the cube");
ADD_PROPERTY_TYPE(Height, (10.0f), "Cube", App::Prop_None, "The height of the cube");
ADD_PROPERTY_TYPE(Length, (10.0F), "Cube", App::Prop_None, "The length of the cube");
ADD_PROPERTY_TYPE(Width, (10.0F), "Cube", App::Prop_None, "The width of the cube");
ADD_PROPERTY_TYPE(Height, (10.0F), "Cube", App::Prop_None, "The height of the cube");
Length.setConstraints(&floatRange);
Width.setConstraints(&floatRange);
Height.setConstraints(&floatRange);
@@ -332,14 +327,13 @@ App::DocumentObjectExecReturn* Cube::execute()
std::unique_ptr<MeshObject> mesh(MeshObject::createCube((float)Length.getValue(),
(float)Width.getValue(),
(float)Height.getValue()));
if (mesh.get()) {
if (mesh) {
mesh->setPlacement(this->Placement.getValue());
Mesh.setValue(mesh->getKernel());
return App::DocumentObject::StdReturn;
}
else {
return new App::DocumentObjectExecReturn("Cannot create cube", this);
}
return new App::DocumentObjectExecReturn("Cannot create cube", this);
}
void Cube::handleChangedPropertyType(Base::XMLReader& reader,