kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[TD]fix asCircle error calculation

Browse Source
This commit is contained in:
wandererfan
2024-08-17 19:48:06 -04:00
committed by WandererFan
parent 73c827d928
commit 7cce01368c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Mod/TechDraw/App/Geometry.cpp
View File

@@ -1593,7 +1593,6 @@ bool GeometryUtils::getCircleParms(TopoDS_Edge occEdge, double& radius, Base::Ve
sumCenter += DrawUtil::toVector3d(curveCenter);
}
catch (Standard_Failure&) {
// Base::Console().Error("OCC error. Could not interpret BSpline as Circle\n");
return false;
}
Base::Vector3d avgCenter = sumCenter/testCount;
@@ -1601,7 +1600,7 @@ bool GeometryUtils::getCircleParms(TopoDS_Edge occEdge, double& radius, Base::Ve
double avgCurve = sumCurvature/testCount;
double errorCurve = 0;
for (auto& cv: curvatures) {
errorCurve += fabs(avgCurve - cv); //fabs???
errorCurve += avgCurve - cv;
}
errorCurve = errorCurve/testCount;
@@ -1617,6 +1616,7 @@ bool GeometryUtils::getCircleParms(TopoDS_Edge occEdge, double& radius, Base::Ve
//! make a circle or arc of circle Edge from BSpline Edge
//! assumes the spline is generally circular but does not check
// ??? why does this not use getCircleParms to retrieve centre, radius, start/end, isArc
TopoDS_Edge GeometryUtils::asCircle(TopoDS_Edge splineEdge, bool& arc)
{
BRepAdaptor_Curve curveAdapt(splineEdge);