From 7e57b6e7b0fccdb32950a7849f02fd14941ee603 Mon Sep 17 00:00:00 2001
From: PaddleStroke <pierrelouis.boyer@gmail.com>
Date: Mon, 8 Sep 2025 18:26:30 +0200
Subject: [PATCH] PartDesign: FeatureLinearPattern fix Axis-Y not working
 (#23637)

* PartDesign: FeatureLinearPattern prevent error message

* To squash
---
 src/Gui/ComboLinks.cpp                          |  4 ----
 src/Mod/PartDesign/App/FeatureLinearPattern.cpp | 16 ++++++++++------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/Gui/ComboLinks.cpp b/src/Gui/ComboLinks.cpp
index a1dc242f35..70c1dec605 100644
--- a/src/Gui/ComboLinks.cpp
+++ b/src/Gui/ComboLinks.cpp
@@ -85,10 +85,6 @@ namespace Gui {
     {
         App::PropertyLinkSub lnk;
         std::vector<std::string> sub = { linkSubname };
-        // Handle empty subname correctly
-        if (linkSubname.empty()) {
-            sub.clear();
-        }
         lnk.setValue(linkObj, sub);
         return addLink(lnk, itemText, userData);
     }
diff --git a/src/Mod/PartDesign/App/FeatureLinearPattern.cpp b/src/Mod/PartDesign/App/FeatureLinearPattern.cpp
index cde5e2013d..52c7639dff 100644
--- a/src/Mod/PartDesign/App/FeatureLinearPattern.cpp
+++ b/src/Mod/PartDesign/App/FeatureLinearPattern.cpp
@@ -248,17 +248,20 @@ const std::list<gp_Trsf> LinearPattern::getTransformations(const std::vector<App
 
 gp_Vec LinearPattern::calculateOffsetVector(LinearPatternDirection dir) const
 {
-    const auto& occurrencesProp =
-        (dir == LinearPatternDirection::First) ? Occurrences : Occurrences2;
+    bool firstDir = dir == LinearPatternDirection::First;
+    const auto& occurrencesProp = firstDir ? Occurrences : Occurrences2;
     int occurrences = occurrencesProp.getValue();
     if (occurrences <= 1) {
         return gp_Vec();  // Return zero vector if no transformation is needed
     }
 
-    const auto& dirProp = (dir == LinearPatternDirection::First) ? Direction : Direction2;
-    const auto& reversedProp = (dir == LinearPatternDirection::First) ? Reversed : Reversed2;
-    const auto& modeProp = (dir == LinearPatternDirection::First) ? Mode : Mode2;
-    const auto& lengthProp = (dir == LinearPatternDirection::First) ? Length : Length2;
+    const auto& dirProp = firstDir ? Direction : Direction2;
+    if (!dirProp.getValue()) {
+        return gp_Vec();
+    }
+    const auto& reversedProp = firstDir ? Reversed : Reversed2;
+    const auto& modeProp = firstDir ? Mode : Mode2;
+    const auto& lengthProp = firstDir ? Length : Length2;
 
     double distance = lengthProp.getValue();
     if (distance < Precision::Confusion()) {
@@ -552,3 +555,4 @@ void LinearPattern::syncLengthAndOffset(LinearPatternDirection dir)
 
 }
 
+