From 7e9fa4de99cbd734ae0dab5c21de9e34c79f9330 Mon Sep 17 00:00:00 2001 From: Kacper Donat Date: Sat, 9 Nov 2024 20:27:57 +0100 Subject: [PATCH] TopoNaming: Refine - mark joined faces as modified not generated This is parity change with LS3: https://github.com/realthunder/FreeCAD/blob/a9810d509a6f112b5ac03d4d4831b67e6bffd5b7/src/Mod/Part/App/TopoShapeEx.cpp#L3357 --- src/Mod/Part/App/TopoShapeExpansion.cpp | 2 +- .../PartDesign/PartDesignTests/TestTopologicalNamingProblem.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Mod/Part/App/TopoShapeExpansion.cpp b/src/Mod/Part/App/TopoShapeExpansion.cpp index 87bfd083a4..31f4f70105 100644 --- a/src/Mod/Part/App/TopoShapeExpansion.cpp +++ b/src/Mod/Part/App/TopoShapeExpansion.cpp @@ -4630,7 +4630,7 @@ public: if (it.Key().IsNull()) { continue; } - mapper.populate(MappingStatus::Generated, it.Key(), it.Value()); + mapper.populate(MappingStatus::Modified, it.Key(), it.Value()); } } }; diff --git a/src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py b/src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py index f59cadda68..f7a456c0b9 100644 --- a/src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py +++ b/src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py @@ -621,7 +621,7 @@ class TestTopologicalNamingProblem(unittest.TestCase): self.assertEqual(self.countFacesEdgesVertexes(revolution.Shape.ElementReverseMap), (9, 21, 14)) self.assertEqual( revolution.Shape.ElementReverseMap["Vertex9"][1].count(";"), 3) - self.assertEqual( revolution.Shape.ElementReverseMap["Face9"].count(";"), 16) + self.assertEqual( revolution.Shape.ElementReverseMap["Face9"].count(";"), 14) # Arrange for an UpToFace mode test revolution.Type = 3 revolution.UpToFace = (pad, ("Face4"))