From 817ffc5782097bbd6534118178bc4d52a8b3c123 Mon Sep 17 00:00:00 2001 From: tetektoza Date: Sat, 13 Sep 2025 12:21:26 +0200 Subject: [PATCH] Gui: Make Report View properly claim Select All (Ctrl+A) shortcut Currently if user tries to use CTRL+A on Report View while having document opened, it rejects the action and nothing happens. This happened during the introduction of Select All (CTRL+A) behavior in Sketcher. Basically, before Report View was not catching the event, but neither any widget, resulting in QTextEdit catching it at the end of the chain. Now, after enabling it for the whole document, Report View rejected it, but we have registered it throughout the document, so another widget was intercepting the event. So, fix for that is simple - add a check for Select All shortcut on Report View level, so the event will get consumed instead of being rejected and propagated to further widgets. --- src/Gui/ReportView.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Gui/ReportView.cpp b/src/Gui/ReportView.cpp index cab2425ec4..e260f2a35d 100644 --- a/src/Gui/ReportView.cpp +++ b/src/Gui/ReportView.cpp @@ -555,7 +555,7 @@ bool ReportOutput::event(QEvent* event) { if (event && event->type() == QEvent::ShortcutOverride) { auto kevent = static_cast(event); - if (kevent == QKeySequence::Copy) + if (kevent == QKeySequence::Copy || kevent == QKeySequence::SelectAll) kevent->accept(); } return QTextEdit::event(event);