kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: SketchGeometryExtension refactor InternalGeometry string conversion

Browse Source 
=============================================================================

Minor refactoring to centralise string to enum conversion in a single place
This commit is contained in:
Abdullah Tahiri
2020-11-14 06:54:01 +01:00
committed by abdullahtahiriyo
parent 4391b3217f
commit 818ffa91ce
4 changed files with 28 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/Mod/Sketcher/App/SketchGeometryExtensionPyImp.cpp
View File

@@ -104,18 +104,11 @@ Py::String SketchGeometryExtensionPy::getInternalType(void) const
void SketchGeometryExtensionPy::setInternalType(Py::String arg)
{
std::string argstr = arg;
InternalType::InternalType type;
auto pos = std::find_if(this->getSketchGeometryExtensionPtr()->internaltype2str.begin(),
getSketchGeometryExtensionPtr()->internaltype2str.end(),
[argstr](const char * val) {
return strcmp(val,argstr.c_str())==0;}
);
if( pos != getSketchGeometryExtensionPtr()->internaltype2str.end()) {
int index = std::distance( getSketchGeometryExtensionPtr()->internaltype2str.begin(), pos );
this->getSketchGeometryExtensionPtr()->setInternalType((InternalType::InternalType)index);
return;
if(SketchGeometryExtension::getInternalTypeFromName(argstr, type)) {
this->getSketchGeometryExtensionPtr()->setInternalType(type);
return;
}
throw Py::ValueError("Argument is not a valid internal geometry type.");