fix (Qt) issues found by clang's clazy tool:

+ -Wclazy-incorrect-emit
+ -Wclazy-strict-iterators
+ -Wclazy-overloaded-signal
+ -Wclazy-qstring-arg
+ -Wclazy-unused-non-trivial-variable
+ -Wclazy-container-anti-pattern
+ -Wclazy-range-loop-reference
+ -Wclazy-const-signal-or-slot
+ -Wclazy-detaching-temporary
+ -Wclazy-qfileinfo-exists
This commit is contained in:
wmayer
2022-06-29 21:00:54 +02:00
parent fc8ccd59ed
commit 82a6241fc5
49 changed files with 185 additions and 180 deletions

View File

@@ -436,7 +436,7 @@ void PropertyModel::updateProperty(const App::Property& prop)
QModelIndex parent = this->index(item->parent()->row(), 0, QModelIndex());
item->assignProperty(&prop);
QModelIndex data = this->index(item->row(), column, parent);
dataChanged(data, data);
Q_EMIT dataChanged(data, data);
updateChildren(item, column, data);
}
@@ -492,7 +492,7 @@ void PropertyModel::updateChildren(PropertyItem* item, int column, const QModelI
if (numChild > 0) {
QModelIndex topLeft = this->index(0, column, parent);
QModelIndex bottomRight = this->index(numChild, column, parent);
dataChanged(topLeft, bottomRight);
Q_EMIT dataChanged(topLeft, bottomRight);
#if 0 // It seems we don't have to inform grand children
for (int row=0; row<numChild; row++) {
PropertyItem* child = item->child(row);