kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Fix several clazy issues:

Browse Source 
* C++11 range-loop might detach Qt container [-Wclazy-range-loop-detach]
This commit is contained in:
wmayer
2022-07-24 23:48:37 +02:00
parent 25483b78be
commit 85bd6b5c6b
17 changed files with 63 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Gui/TaskElementColors.cpp
View File

@@ -215,7 +215,8 @@ public:
}
void removeItems() {
for(auto item : ui->elementList->selectedItems()) {
const auto items = ui->elementList->selectedItems();
for(auto item : items) {
std::string sub = qPrintable(item->data(Qt::UserRole+1).value<QString>());
if(sub == hiddenSub)
hiddenSub.clear();
@@ -259,8 +260,8 @@ public:
editObj == msg.pObjectName &&
boost::starts_with(msg.pSubName,editSub))
{
for(auto item : ui->elementList->findItems(
QString::fromLatin1(msg.pSubName-editSub.size()), Qt::MatchExactly))
const auto items = ui->elementList->findItems(QString::fromLatin1(msg.pSubName-editSub.size()), Qt::MatchExactly);
for(auto item : items)
item->setSelected(msg.Type==SelectionChanges::AddSelection);
}
}
@@ -285,7 +286,8 @@ public:
}
break;
}
for(auto item : ui->elementList->selectedItems()) {
const auto items = ui->elementList->selectedItems();
for(auto item : items) {
std::string name(qPrintable(item->data(Qt::UserRole+1).value<QString>()));
if(ViewProvider::hasHiddenMarker(name.c_str()))
continue;