kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

TD: Fix memory leaks with PySequence_GetItem

Browse Source
This commit is contained in:
wmayer
2024-05-09 00:03:01 +02:00
parent 03a371d6e3
commit 85d3d9eec0
5 changed files with 29 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Mod/TechDraw/App/PropertyCosmeticVertexList.cpp
View File

@@ -97,19 +97,20 @@ void PropertyCosmeticVertexList::setPyObject(PyObject *value)
// check container of this property to notify about changes
if (PySequence_Check(value)) {
Py_ssize_t nSize = PySequence_Size(value);
Py::Sequence sequence(value);
Py_ssize_t nSize = sequence.size();
std::vector<CosmeticVertex*> values;
values.resize(nSize);
for (Py_ssize_t i=0; i < nSize; ++i) {
PyObject* item = PySequence_GetItem(value, i);
if (!PyObject_TypeCheck(item, &(CosmeticVertexPy::Type))) {
Py::Object item = sequence.getItem(i);
if (!PyObject_TypeCheck(item.ptr(), &(CosmeticVertexPy::Type))) {
std::string error = std::string("types in list must be 'CosmeticVertex', not ");
error += item->ob_type->tp_name;
error += item.ptr()->ob_type->tp_name;
throw Base::TypeError(error);
}
values[i] = static_cast<CosmeticVertexPy*>(item)->getCosmeticVertexPtr();
values[i] = static_cast<CosmeticVertexPy*>(item.ptr())->getCosmeticVertexPtr();
}
setValues(values);