From 85e85db7eae71663e75ca837b70d4aeb4014c5e4 Mon Sep 17 00:00:00 2001 From: Joao Matos Date: Sun, 24 Aug 2025 19:08:31 +0100 Subject: [PATCH] FastSignals: Fix Clang Tidy issues. --- .../libfastsignals/include/fastsignals/bind_weak.h | 6 +++++- .../libfastsignals/include/fastsignals/connection.h | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/bind_weak.h b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/bind_weak.h index bd95b0eca7..64d4b69f15 100644 --- a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/bind_weak.h +++ b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/bind_weak.h @@ -1,5 +1,9 @@ #pragma once +#include +#include +#include + namespace fastsignals { namespace detail @@ -14,7 +18,7 @@ struct weak_binder weak_binder(MethodType pMethod, WeakPtrType&& pObject) : m_pMethod(pMethod) - , m_pObject(pObject) + , m_pObject(std::move(pObject)) { } diff --git a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/connection.h b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/connection.h index bc06075013..2890f19d66 100644 --- a/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/connection.h +++ b/src/3rdParty/FastSignals/libfastsignals/include/fastsignals/connection.h @@ -19,6 +19,7 @@ public: connection& operator=(const connection& other) noexcept; connection(connection&& other) noexcept; connection& operator=(connection&& other) noexcept; + ~connection() = default; bool connected() const noexcept; void disconnect() noexcept; @@ -49,6 +50,7 @@ public: advanced_connection& operator=(const advanced_connection&) noexcept; advanced_connection(advanced_connection&& other) noexcept; advanced_connection& operator=(advanced_connection&& other) noexcept; + ~advanced_connection() = default; protected: impl_ptr m_impl;