kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Activate Part/Part Design check and refine preferences by default (#14406)

Browse Source 
* Activate Part/Part Design check and refine preferences by default

* added bool in .ui

* Update tests

* Fix Sketcher tests
This commit is contained in:
Max Wilfinger
2024-07-01 17:50:42 +02:00
committed by GitHub
parent 96731cbd66
commit 86b1c2e863
10 changed files with 25 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/Part/App/FeaturePartBoolean.cpp
View File

@@ -124,7 +124,7 @@ App::DocumentObjectExecReturn* Boolean::execute()
->GetGroup("Preferences")
->GetGroup("Mod/Part/Boolean");
if (hGrp->GetBool("CheckModel", false)) {
if (hGrp->GetBool("CheckModel", true)) {
BRepCheck_Analyzer aChecker(resShape);
if (!aChecker.IsValid()) {
return new App::DocumentObjectExecReturn("Resulting shape is invalid");

4
src/Mod/Part/App/FeaturePartCommon.cpp
View File

@@ -147,7 +147,7 @@ App::DocumentObjectExecReturn *MultiCommon::execute()
Base::Reference<ParameterGrp> hGrp = App::GetApplication().GetUserParameter()
.GetGroup("BaseApp")->GetGroup("Preferences")->GetGroup("Mod/Part/Boolean");
if (hGrp->GetBool("CheckModel", false)) {
if (hGrp->GetBool("CheckModel", true)) {
BRepCheck_Analyzer aChecker(resShape);
if (! aChecker.IsValid() ) {
return new App::DocumentObjectExecReturn("Resulting shape is invalid");
@@ -222,7 +222,7 @@ App::DocumentObjectExecReturn *MultiCommon::execute()
.GetGroup("BaseApp")
->GetGroup("Preferences")
->GetGroup("Mod/Part/Boolean");
if (hGrp->GetBool("CheckModel", false)) {
if (hGrp->GetBool("CheckModel", true)) {
BRepCheck_Analyzer aChecker(res.getShape());
if (!aChecker.IsValid()) {
return new App::DocumentObjectExecReturn("Resulting shape is invalid");

4
src/Mod/Part/App/FeaturePartFuse.cpp
View File

@@ -148,7 +148,7 @@ App::DocumentObjectExecReturn *MultiFuse::execute()
Base::Reference<ParameterGrp> hGrp = App::GetApplication().GetUserParameter()
.GetGroup("BaseApp")->GetGroup("Preferences")->GetGroup("Mod/Part/Boolean");
if (hGrp->GetBool("CheckModel", false)) {
if (hGrp->GetBool("CheckModel", true)) {
BRepCheck_Analyzer aChecker(resShape);
if (! aChecker.IsValid() ) {
return new App::DocumentObjectExecReturn("Resulting shape is invalid");
@@ -268,7 +268,7 @@ App::DocumentObjectExecReturn *MultiFuse::execute()
.GetGroup("BaseApp")
->GetGroup("Preferences")
->GetGroup("Mod/Part/Boolean");
if (hGrp->GetBool("CheckModel", false)) {
if (hGrp->GetBool("CheckModel", true)) {
BRepCheck_Analyzer aChecker(res.getShape());
if (!aChecker.IsValid()) {
return new App::DocumentObjectExecReturn("Resulting shape is invalid");

9
src/Mod/Part/Gui/DlgSettingsGeneral.ui
View File

@@ -25,6 +25,9 @@
<property name="text">
<string>Automatically check model after boolean operation</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
<property name="prefEntry" stdset="0">
<cstring>CheckModel</cstring>
</property>
@@ -38,6 +41,9 @@
<property name="text">
<string>Automatically refine model after boolean operation</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
<property name="prefEntry" stdset="0">
<cstring>RefineModel</cstring>
</property>
@@ -51,6 +57,9 @@
<property name="text">
<string>Automatically refine model after sketch-based operation</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
<property name="prefEntry" stdset="0">
<cstring>RefineModel</cstring>
</property>