kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: Do not consider missing external geometry to be an error (#16590)

Browse Source 
* Do not consider missing external geometry to be an error; highlight in conflict color.
This commit is contained in:
bgbsww
2024-09-18 16:18:11 -04:00
committed by GitHub
parent 8fb03c0583
commit 888391414d
3 changed files with 93 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Mod/Sketcher/App/SketchObject.cpp
View File

@@ -266,9 +266,11 @@ App::DocumentObjectExecReturn* SketchObject::execute()
Constraints.acceptGeometry(getCompleteGeometry());
}
catch (const Base::Exception& e) {
Base::Console().Error("%s\nClear constraints to external geometry\n", e.what());
// 9/16/24: We used to clear the constraints here, but we no longer want to do that
// as missing reference geometry is not considered an error while we sort out sketcher UI.
// Base::Console().Error("%s\nClear constraints to external geometry\n", e.what());
// we cannot trust the constraints of external geometries, so remove them
delConstraintsToExternal();
// delConstraintsToExternal();
}
// This includes a regular solve including full geometry update, except when an error