From 89cf78b26273fd18a9690e3fea905c3358f23948 Mon Sep 17 00:00:00 2001
From: Yorik van Havre <yorik@uncreated.net>
Date: Tue, 8 Jan 2019 15:44:45 -0200
Subject: [PATCH] Arch: Fixed Reference object that cannot be deleted

---
 src/Mod/Arch/ArchReference.py | 41 ++++++++++++++++++++---------------
 1 file changed, 24 insertions(+), 17 deletions(-)

diff --git a/src/Mod/Arch/ArchReference.py b/src/Mod/Arch/ArchReference.py
index af50726658..982daa7955 100644
--- a/src/Mod/Arch/ArchReference.py
+++ b/src/Mod/Arch/ArchReference.py
@@ -392,6 +392,7 @@ class ViewProviderArchReference:
         if hasattr(self,"timer"):
             self.timer.stop()
             del self.timer
+            return True
 
     def setupContextMenu(self,vobj,menu):
 
@@ -463,6 +464,28 @@ class ArchReferenceTaskPanel:
         QtCore.QObject.connect(self.fileButton, QtCore.SIGNAL("clicked()"), self.chooseFile)
         QtCore.QObject.connect(self.openButton, QtCore.SIGNAL("clicked()"), self.openFile)
 
+    def accept(self):
+
+        if self.filename:
+            if self.filename != self.obj.File:
+                self.obj.File = self.filename
+                FreeCAD.ActiveDocument.recompute()
+        if self.partCombo.currentText():
+            i = self.partCombo.currentIndex()
+            if self.partCombo.itemData(i) != self.obj.Part:
+                self.obj.Part = self.partCombo.itemData(i)
+                if self.obj.Label == "External Reference":
+                    self.obj.Label = self.partCombo.itemText(i)
+                FreeCAD.ActiveDocument.recompute()
+        FreeCADGui.ActiveDocument.resetEdit()
+        return True
+
+    def reject(self):
+
+        FreeCAD.ActiveDocument.recompute()
+        FreeCADGui.ActiveDocument.resetEdit()
+        return True
+
     def chooseFile(self):
 
         loc = QtCore.QDir.homePath()
@@ -482,28 +505,12 @@ class ArchReferenceTaskPanel:
                         self.partCombo.setCurrentIndex(sorted(parts.keys()).index(self.obj.Part))
 
     def openFile(self):
+
         if self.obj.File:
             FreeCAD.openDocument(self.obj.File)
             FreeCADGui.Control.closeDialog()
             FreeCADGui.ActiveDocument.resetEdit()
 
-    def accept(self):
-
-        if self.filename:
-            if self.filename != self.obj.File:
-                self.obj.File = self.filename
-                FreeCAD.ActiveDocument.recompute()
-        if self.partCombo.currentText():
-            i = self.partCombo.currentIndex()
-            if self.partCombo.itemData(i) != self.obj.Part:
-                self.obj.Part = self.partCombo.itemData(i)
-                if self.obj.Label == "External Reference":
-                    self.obj.Label = self.partCombo.itemText(i)
-                FreeCAD.ActiveDocument.recompute()
-        FreeCADGui.ActiveDocument.resetEdit()
-        return True
-
-
 
 class ArchReferenceCommand: