kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Eliminate some redundant executes

Browse Source 
- excessive calls to DrawView::execute were
  slowing data entry in PropertyEditor.
This commit is contained in:
wandererfan
2018-05-04 10:28:03 -04:00
committed by Yorik van Havre
parent 6b91a3ec32
commit 8a183a0ba0
12 changed files with 58 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Mod/TechDraw/Gui/QGIView.cpp
View File

@@ -266,19 +266,20 @@ void QGIView::updateView(bool update)
} else {
setFlag(QGraphicsItem::ItemIsMovable, true);
}
if (update ||
getViewObject()->X.isTouched() ||
if (getViewObject()->X.isTouched() ||
getViewObject()->Y.isTouched()) {
double featX = Rez::guiX(getViewObject()->X.getValue());
double featY = Rez::guiX(getViewObject()->Y.getValue());
setPosition(featX,featY);
}
if (update ||
getViewObject()->Rotation.isTouched() ) {
if (getViewObject()->Rotation.isTouched() ) {
rotateView();
}
draw();
if (update)
QGraphicsItem::update();
}
@@ -484,8 +485,11 @@ QGIView* QGIView::getQGIVByName(std::string name)
/* static */
Gui::ViewProvider* QGIView::getViewProvider(App::DocumentObject* obj)
{
Gui::Document* guiDoc = Gui::Application::Instance->getDocument(obj->getDocument());
Gui::ViewProvider* result = guiDoc->getViewProvider(obj);
Gui::ViewProvider* result = nullptr;
if (obj != nullptr) {
Gui::Document* guiDoc = Gui::Application::Instance->getDocument(obj->getDocument());
result = guiDoc->getViewProvider(obj);
}
return result;
}