kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Update to Toposhape versions and fix shapebinder references with test (#16036)

Browse Source 
* Update to Toposhape versions and fix shapebinder references with test

* Update src/Mod/PartDesign/PartDesignTests/TestShapeBinder.py

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
This commit is contained in:
bgbsww
2024-08-26 11:50:18 -04:00
committed by GitHub
parent f10a8b63d1
commit 8c08549f5a
6 changed files with 46 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Mod/PartDesign/App/FeatureSketchBased.cpp
View File

@@ -758,7 +758,8 @@ void ProfileBased::getFaceFromLinkSub(TopoDS_Face& upToFace, const App::Property
throw Base::TypeError("SketchBased: Must be face of a feature");
Part::TopoShape baseShape = static_cast<Part::Feature*>(ref)->Shape.getShape();
if (subStrings.empty() || subStrings[0].empty())
// Allow an empty sub here - example is a sketch reference (no sub) that creates a face.
if (subStrings.empty() )
throw Base::ValueError("SketchBased: No face selected");
// TODO: Check for multiple UpToFaces?