Sketcher: onUndoRedoFinished implementation and request

=======================================================

The sketchobject is now left in a known status after undo/redo transaction
This commit is contained in:
Abdullah Tahiri
2020-06-13 07:26:02 +02:00
committed by wwmayer
parent df4a8eb7ab
commit 8ef32eab8b
2 changed files with 21 additions and 1 deletions

View File

@@ -6804,7 +6804,12 @@ void SketchObject::onChanged(const App::Property* prop)
}
}
if (prop == &Geometry || prop == &Constraints) {
Constraints.checkGeometry(getCompleteGeometry());
if(getDocument()->isPerformingTransaction()) {
setStatus(App::PendingTransactionUpdate, true);
}
else {
Constraints.checkGeometry(getCompleteGeometry());
}
}
else if (prop == &ExternalGeometry) {
// make sure not to change anything while restoring this object
@@ -6832,6 +6837,19 @@ void SketchObject::onChanged(const App::Property* prop)
Part::Part2DObject::onChanged(prop);
}
void SketchObject::onUndoRedoFinished()
{
// upon undo/redo, PropertyConstraintList does not have updated valid geometry keys, which results in empty constraint lists
// when using getValues
//
// The sketch will also have invalid vertex indices, requiring a call to rebuildVertexIndex
//
// Historically this was "solved" by issuing a recompute, which is absolutely unnecessary and prevents solve() from working before
// such a recompute
acceptGeometry();
solve();
}
void SketchObject::onDocumentRestored()
{
try {

View File

@@ -432,6 +432,8 @@ protected:
// check whether constraint may be changed driving status
int testDrivingChange(int ConstrId, bool isdriving);
virtual void onUndoRedoFinished() override;
private:
/// Flag to allow external geometry from other bodies than the one this sketch belongs to
bool allowOtherBody;