From 90c4ffceecb3356b101fc95757d3aeb9cea48c11 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Skowro=C5=84ski?= <skowri@gmail.com>
Date: Mon, 28 Dec 2020 19:59:14 +0100
Subject: [PATCH] Fix GCC warnings: catching polymorphic type by value
 [-Wcatch-value=]

---
 src/Mod/Part/App/GeometryPyImp.cpp                   | 6 +++---
 src/Mod/Sketcher/App/ExternalGeometryFacadePyImp.cpp | 6 +++---
 src/Mod/Sketcher/App/GeometryFacadePyImp.cpp         | 6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/Mod/Part/App/GeometryPyImp.cpp b/src/Mod/Part/App/GeometryPyImp.cpp
index ded486b763..9e288adf8e 100644
--- a/src/Mod/Part/App/GeometryPyImp.cpp
+++ b/src/Mod/Part/App/GeometryPyImp.cpp
@@ -259,7 +259,7 @@ PyObject* GeometryPy::getExtensionOfType(PyObject *args)
                 PyErr_SetString(PartExceptionOCCError, "Geometry extension does not exist anymore.");
                 return 0;
             }
-            catch(Base::NotImplementedError) {
+            catch(Base::NotImplementedError&) {
                 PyErr_SetString(Part::PartExceptionOCCError, "Geometry extension does not implement a Python counterpart.");
                 return 0;
             }
@@ -296,7 +296,7 @@ PyObject* GeometryPy::getExtensionOfName(PyObject *args)
             PyErr_SetString(PartExceptionOCCError, "Geometry extension does not exist anymore.");
             return 0;
         }
-        catch(Base::NotImplementedError) {
+        catch(Base::NotImplementedError&) {
             PyErr_SetString(Part::PartExceptionOCCError, "Geometry extension does not implement a Python counterpart.");
             return 0;
         }
@@ -425,7 +425,7 @@ PyObject* GeometryPy::getExtensions(PyObject *args)
                 try {
                     list.append(Py::asObject(p->copyPyObject()));
                 }
-                catch(Base::NotImplementedError) {
+                catch(Base::NotImplementedError&) {
                     // silently ignoring extensions not having a Python object
                 }
             }
diff --git a/src/Mod/Sketcher/App/ExternalGeometryFacadePyImp.cpp b/src/Mod/Sketcher/App/ExternalGeometryFacadePyImp.cpp
index 13095bec3c..adfb68ea05 100644
--- a/src/Mod/Sketcher/App/ExternalGeometryFacadePyImp.cpp
+++ b/src/Mod/Sketcher/App/ExternalGeometryFacadePyImp.cpp
@@ -316,7 +316,7 @@ PyObject* ExternalGeometryFacadePy::getExtensionOfType(PyObject *args)
                 PyErr_SetString(Part::PartExceptionOCCError, "Geometry extension does not exist anymore.");
                 return 0;
             }
-            catch(Base::NotImplementedError) {
+            catch(Base::NotImplementedError&) {
                 PyErr_SetString(Part::PartExceptionOCCError, "Geometry extension does not implement a Python counterpart.");
                 return 0;
             }
@@ -353,7 +353,7 @@ PyObject* ExternalGeometryFacadePy::getExtensionOfName(PyObject *args)
             PyErr_SetString(Part::PartExceptionOCCError, "Geometry extension does not exist anymore.");
             return 0;
         }
-        catch(Base::NotImplementedError) {
+        catch(Base::NotImplementedError&) {
             PyErr_SetString(Part::PartExceptionOCCError, "Geometry extension does not implement a Python counterpart.");
             return 0;
         }
@@ -480,7 +480,7 @@ PyObject* ExternalGeometryFacadePy::getExtensions(PyObject *args)
                 try {
                     list.append(Py::asObject(p->copyPyObject()));
                 }
-                catch(Base::NotImplementedError) {
+                catch(Base::NotImplementedError&) {
                     // silently ignoring extensions not having a Python object
                 }
             }
diff --git a/src/Mod/Sketcher/App/GeometryFacadePyImp.cpp b/src/Mod/Sketcher/App/GeometryFacadePyImp.cpp
index ab00cba9b6..b99d9a0340 100644
--- a/src/Mod/Sketcher/App/GeometryFacadePyImp.cpp
+++ b/src/Mod/Sketcher/App/GeometryFacadePyImp.cpp
@@ -295,7 +295,7 @@ PyObject* GeometryFacadePy::getExtensionOfType(PyObject *args)
                 PyErr_SetString(Part::PartExceptionOCCError, "Geometry extension does not exist anymore.");
                 return 0;
             }
-            catch(Base::NotImplementedError) {
+            catch(Base::NotImplementedError&) {
                 PyErr_SetString(Part::PartExceptionOCCError, "Geometry extension does not implement a Python counterpart.");
                 return 0;
             }
@@ -332,7 +332,7 @@ PyObject* GeometryFacadePy::getExtensionOfName(PyObject *args)
             PyErr_SetString(Part::PartExceptionOCCError, "Geometry extension does not exist anymore.");
             return 0;
         }
-        catch(Base::NotImplementedError) {
+        catch(Base::NotImplementedError&) {
             PyErr_SetString(Part::PartExceptionOCCError, "Geometry extension does not implement a Python counterpart.");
             return 0;
         }
@@ -458,7 +458,7 @@ PyObject* GeometryFacadePy::getExtensions(PyObject *args)
                 try {
                     list.append(Py::asObject(p->copyPyObject()));
                 }
-                catch(Base::NotImplementedError) {
+                catch(Base::NotImplementedError&) {
                     // silently ignoring extensions not having a Python object
                 }
             }