From 92d25a3a780aeb00cc9fbadb2e4f4ba59e387cef Mon Sep 17 00:00:00 2001 From: Ajinkya Dahale Date: Thu, 10 Apr 2025 20:46:17 +0530 Subject: [PATCH] [Sketcher] [WIP] One curious refactor I'm not certain about Possibly reduces "cognitive complexity", but is it really too much clearer? --- src/Mod/Sketcher/Gui/DrawSketchDefaultHandler.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Mod/Sketcher/Gui/DrawSketchDefaultHandler.h b/src/Mod/Sketcher/Gui/DrawSketchDefaultHandler.h index 55a60b280a..95a0c79e58 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchDefaultHandler.h +++ b/src/Mod/Sketcher/Gui/DrawSketchDefaultHandler.h @@ -674,10 +674,11 @@ protected: // find if there is already a matching tangency auto itOfTangentConstraint = AutoConstraints.end(); if (isStartOrEnd(posId1) && isStartOrEnd(posId2)) { - itOfTangentConstraint = - std::ranges::find_if(AutoConstraints, [&](const auto& ace) { - return ace->Type == Sketcher::Tangent && ace->First == geoId1 - && ace->Second == geoId2; + itOfTangentConstraint = std::ranges::find( + AutoConstraints, + std::tuple {Sketcher::Tangent, geoId1, geoId2}, + [](const auto& ace) { + return std::tuple {ace->Type, ace->First, ace->Second}; }); }