fix several kind of warnings:

+ fix -Wparentheses/-Wlogical-op-parentheses
+ fix -Wunused-variable
+ disable -Wundefined-var-template due to many false-positives (clang)
+ fix -Winconsistent-missing-override
+ fix -Wmaybe-uninitialized
This commit is contained in:
wmayer
2017-10-15 19:12:07 +02:00
parent b2c5466c96
commit 96d01c9200
5 changed files with 8 additions and 9 deletions

View File

@@ -289,7 +289,6 @@ void Gui::QuantitySpinBox::setExpression(boost::shared_ptr<Expression> expr)
QString QuantitySpinBox::boundToName() const
{
Q_D(const QuantitySpinBox);
if (isBound()) {
std::string path = getPath().toString();
return QString::fromStdString(path);
@@ -305,7 +304,6 @@ QString QuantitySpinBox::boundToName() const
*/
void QuantitySpinBox::setBoundToByName(const QString &name)
{
Q_D(QuantitySpinBox);
try {
// get document
App::Document *doc = App::GetApplication().getActiveDocument();
@@ -350,7 +348,6 @@ void QuantitySpinBox::setBoundToByName(const QString &name)
QString Gui::QuantitySpinBox::expressionText() const
{
Q_D(const QuantitySpinBox);
try {
if (hasExpression()) {
return QString::fromStdString(getExpressionString());