kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Coverity: Uninitialized scalar/pointer field

Browse Source
This commit is contained in:
wmayer
2020-07-20 16:10:19 +02:00
parent 560e13c5f2
commit 983939b32d
26 changed files with 141 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Mod/Fem/Gui/ViewProviderFemPostFunction.cpp
View File

@@ -137,7 +137,8 @@ void ViewProviderFemPostFunctionProvider::updateSize() {
PROPERTY_SOURCE(FemGui::ViewProviderFemPostFunction, Gui::ViewProviderDocumentObject)
ViewProviderFemPostFunction::ViewProviderFemPostFunction() : m_autoscale(false), m_isDragging(false)
ViewProviderFemPostFunction::ViewProviderFemPostFunction()
: m_manip(nullptr), m_autoscale(false), m_isDragging(false), m_autoRecompute(false)
{
ADD_PROPERTY_TYPE(AutoScaleFactorX, (1), "AutoScale", App::Prop_Hidden, "Automatic scaling factor");

1
src/Mod/Mesh/Gui/RemeshGmsh.cpp
View File

@@ -51,6 +51,7 @@ public:
Private(QWidget* parent)
: gmsh(parent)
{
/* coverity[uninit_ctor] Members of ui are set in setupUI() */
}
void appendText(const QString& text, bool error) {

5
src/Mod/Part/Gui/SoBrepEdgeSet.cpp
View File

@@ -77,8 +77,9 @@ void SoBrepEdgeSet::initClass()
}
SoBrepEdgeSet::SoBrepEdgeSet()
:selContext(std::make_shared<SelContext>())
,selContext2(std::make_shared<SelContext>())
: selContext(std::make_shared<SelContext>())
, selContext2(std::make_shared<SelContext>())
, packedColor(0)
{
SO_NODE_CONSTRUCTOR(SoBrepEdgeSet);
}

1
src/Mod/Part/Gui/SoBrepFaceSet.cpp
View File

@@ -177,6 +177,7 @@ SoBrepFaceSet::SoBrepFaceSet()
selContext = std::make_shared<SelContext>();
selContext2 = std::make_shared<SelContext>();
packedColor = 0;
pimpl.reset(new VBO);
}

5
src/Mod/Part/Gui/SoBrepPointSet.cpp
View File

@@ -72,8 +72,9 @@ void SoBrepPointSet::initClass()
}
SoBrepPointSet::SoBrepPointSet()
:selContext(std::make_shared<SelContext>())
,selContext2(std::make_shared<SelContext>())
: selContext(std::make_shared<SelContext>())
, selContext2(std::make_shared<SelContext>())
, packedColor(0)
{
SO_NODE_CONSTRUCTOR(SoBrepPointSet);
}

1
src/Mod/TechDraw/App/DrawPage.cpp
View File

@@ -101,6 +101,7 @@ DrawPage::DrawPage(void)
Scale.setConstraints(&scaleRange);
balloonPlacing = false;
balloonParent = nullptr;
}
DrawPage::~DrawPage()

6
src/Mod/TechDraw/Gui/QGILeaderLine.cpp
View File

@@ -74,8 +74,14 @@ using namespace TechDraw;
//**************************************************************
QGILeaderLine::QGILeaderLine() :
m_parentItem(nullptr),
m_lineWidth(1.0),
m_lineColor(Qt::black),
m_lineStyle(Qt::SolidLine),
m_editPathStyle(Qt::SolidLine),
m_hasHover(false),
m_saveX(0.0),
m_saveY(0.0),
m_blockDraw(false)
{

8
src/Mod/TechDraw/Gui/QGIViewBalloon.cpp
View File

@@ -97,7 +97,9 @@ QGIBalloonLabel::QGIBalloonLabel()
m_labelText = new QGCustomText();
m_labelText->setParentItem(this);
verticalSep = false;
hasHover = false;
parent = nullptr;
}
QVariant QGIBalloonLabel::itemChange(GraphicsItemChange change, const QVariant &value)
@@ -249,8 +251,12 @@ void QGIBalloonLabel::setColor(QColor c)
//**************************************************************
QGIViewBalloon::QGIViewBalloon() :
dvBalloon(nullptr),
hasHover(false),
m_lineWidth(0.0)
m_lineWidth(0.0),
m_obtuse(false),
parent(nullptr),
m_dragInProgress(false)
{
m_ctrl = false;

1
src/Mod/TechDraw/Gui/QGIViewDimension.cpp
View File

@@ -95,6 +95,7 @@ enum SnapMode{
QGIDatumLabel::QGIDatumLabel()
{
verticalSep = false;
posX = 0;
posY = 0;

4
src/Mod/TechDraw/Gui/TaskActiveView.cpp
View File

@@ -68,7 +68,9 @@ using namespace TechDrawGui;
TaskActiveView::TaskActiveView(TechDraw::DrawPage* pageFeat) :
ui(new Ui_TaskActiveView),
m_pageFeat(pageFeat),
m_symbolFeat(nullptr)
m_symbolFeat(nullptr),
m_btnOK(nullptr),
m_btnCancel(nullptr)
{
// Base::Console().Message("TAV::TAV() - create mode\n");
if (m_pageFeat == nullptr) {

10
src/Mod/TechDraw/Gui/TaskCenterLine.cpp
View File

@@ -81,7 +81,11 @@ TaskCenterLine::TaskCenterLine(TechDraw::DrawViewPart* partFeat,
m_partFeat(partFeat),
m_basePage(page),
m_createMode(false),
m_btnOK(nullptr),
m_btnCancel(nullptr),
m_edgeName(edgeName),
m_extendBy(0.0),
m_clIdx(0),
m_type(0), //0 - Face, 1 - 2 Lines, 2 - 2 points
m_mode(0), //0 - vertical, 1 - horizontal, 2 - aligned
m_editMode(editMode)
@@ -114,7 +118,13 @@ TaskCenterLine::TaskCenterLine(TechDraw::DrawViewPart* partFeat,
m_partFeat(partFeat),
m_basePage(page),
m_createMode(true),
m_btnOK(nullptr),
m_btnCancel(nullptr),
m_subNames(subNames),
m_extendBy(0.0),
m_geomIndex(0),
m_cl(nullptr),
m_clIdx(0),
m_type(0), //0 - Face, 1 - 2 Lines, 2 - 2 points
m_mode(0), //0 - vertical, 1 - horizontal, 2 - aligned
m_editMode(editMode)

9
src/Mod/TechDraw/Gui/TaskCosVertex.cpp
View File

@@ -72,10 +72,19 @@ using namespace TechDrawGui;
TaskCosVertex::TaskCosVertex(TechDraw::DrawViewPart* baseFeat,
TechDraw::DrawPage* page) :
ui(new Ui_TaskCosVertex),
blockUpdate(false),
m_tracker(nullptr),
m_mdi(nullptr),
m_scene(nullptr),
m_view(nullptr),
m_baseFeat(baseFeat),
m_basePage(page),
m_qgParent(nullptr),
m_trackerMode(QGTracker::None),
m_saveContextPolicy(Qt::DefaultContextMenu),
m_inProgressLock(false),
m_btnOK(nullptr),
m_btnCancel(nullptr),
m_pbTrackerState(TRACKERPICK),
m_savePoint(QPointF(0.0,0.0)),
pointFromTracker(false)

18
src/Mod/TechDraw/Gui/TaskDetail.cpp
View File

@@ -74,12 +74,21 @@ using namespace Gui;
//creation constructor
TaskDetail::TaskDetail(TechDraw::DrawViewPart* baseFeat):
ui(new Ui_TaskDetail),
blockUpdate(false),
m_ghost(nullptr),
m_mdi(nullptr),
m_scene(nullptr),
m_view(nullptr),
m_detailFeat(nullptr),
m_baseFeat(baseFeat),
m_basePage(nullptr),
m_qgParent(nullptr),
m_inProgressLock(false),
m_btnOK(nullptr),
m_btnCancel(nullptr),
m_saveAnchor(Base::Vector3d(0.0, 0.0, 0.0)),
m_saveRadius(0.0),
m_saved(false),
m_baseName(std::string()),
m_pageName(std::string()),
m_detailName(std::string()),
@@ -143,12 +152,21 @@ TaskDetail::TaskDetail(TechDraw::DrawViewPart* baseFeat):
//edit constructor
TaskDetail::TaskDetail(TechDraw::DrawViewDetail* detailFeat):
ui(new Ui_TaskDetail),
blockUpdate(false),
m_ghost(nullptr),
m_mdi(nullptr),
m_scene(nullptr),
m_view(nullptr),
m_detailFeat(detailFeat),
m_baseFeat(nullptr),
m_basePage(nullptr),
m_qgParent(nullptr),
m_inProgressLock(false),
m_btnOK(nullptr),
m_btnCancel(nullptr),
m_saveAnchor(Base::Vector3d(0.0, 0.0, 0.0)),
m_saveRadius(0.0),
m_saved(false),
m_baseName(std::string()),
m_pageName(std::string()),
m_detailName(std::string()),

28
src/Mod/TechDraw/Gui/TaskLeaderLine.cpp
View File

@@ -73,16 +73,28 @@ using namespace TechDrawGui;
//ctor for edit
TaskLeaderLine::TaskLeaderLine(TechDrawGui::ViewProviderLeader* leadVP) :
ui(new Ui_TaskLeaderLine),
blockUpdate(false),
m_tracker(nullptr),
m_mdi(nullptr),
m_scene(nullptr),
m_view(nullptr),
m_lineVP(leadVP),
m_baseFeat(nullptr),
m_basePage(nullptr),
m_lineFeat(nullptr),
m_qgParent(nullptr),
m_createMode(false),
m_leadLine(nullptr),
m_trackerMode(QGTracker::None),
m_saveContextPolicy(Qt::DefaultContextMenu),
m_inProgressLock(false),
m_qgLine(nullptr),
m_pbTrackerState(TRACKEREDIT)
m_btnOK(nullptr),
m_btnCancel(nullptr),
m_pbTrackerState(TRACKEREDIT),
m_saveX(0.0),
m_saveY(0.0),
m_haveMdi(false)
{
if (m_lineVP == nullptr) {
//should be caught in CMD caller
@@ -155,16 +167,28 @@ TaskLeaderLine::TaskLeaderLine(TechDrawGui::ViewProviderLeader* leadVP) :
TaskLeaderLine::TaskLeaderLine(TechDraw::DrawView* baseFeat,
TechDraw::DrawPage* page) :
ui(new Ui_TaskLeaderLine),
blockUpdate(false),
m_tracker(nullptr),
m_mdi(nullptr),
m_scene(nullptr),
m_view(nullptr),
m_lineVP(nullptr),
m_baseFeat(baseFeat),
m_basePage(page),
m_lineFeat(nullptr),
m_qgParent(nullptr),
m_createMode(true),
m_leadLine(nullptr),
m_trackerMode(QGTracker::None),
m_saveContextPolicy(Qt::DefaultContextMenu),
m_inProgressLock(false),
m_qgLine(nullptr),
m_pbTrackerState(TRACKERPICK)
m_btnOK(nullptr),
m_btnCancel(nullptr),
m_pbTrackerState(TRACKERPICK),
m_saveX(0.0),
m_saveY(0.0),
m_haveMdi(false)
{
if ( (m_basePage == nullptr) ||
(m_baseFeat == nullptr) ) {

21
src/Mod/TechDraw/Gui/TaskRichAnno.cpp
View File

@@ -75,15 +75,23 @@ using namespace TechDrawGui;
//ctor for edit
TaskRichAnno::TaskRichAnno(TechDrawGui::ViewProviderRichAnno* annoVP) :
ui(new Ui_TaskRichAnno),
blockUpdate(false),
m_view(nullptr),
m_annoVP(annoVP),
m_baseFeat(nullptr),
m_basePage(nullptr),
m_annoFeat(nullptr),
m_qgParent(nullptr),
m_createMode(false),
m_text(nullptr),
m_saveContextPolicy(Qt::DefaultContextMenu),
m_inProgressLock(false),
m_qgAnno(nullptr),
m_btnOK(nullptr),
m_btnCancel(nullptr),
m_textDialog(nullptr),
m_rte(nullptr)
m_rte(nullptr),
m_haveMdi(false)
{
// Base::Console().Message("TRA::TRA() - edit\n");
if (m_annoVP == nullptr) {
@@ -142,15 +150,24 @@ TaskRichAnno::TaskRichAnno(TechDrawGui::ViewProviderRichAnno* annoVP) :
TaskRichAnno::TaskRichAnno(TechDraw::DrawView* baseFeat,
TechDraw::DrawPage* page) :
ui(new Ui_TaskRichAnno),
blockUpdate(false),
m_mdi(nullptr),
m_view(nullptr),
m_annoVP(nullptr),
m_baseFeat(baseFeat),
m_basePage(page),
m_annoFeat(nullptr),
m_qgParent(nullptr),
m_createMode(true),
m_text(nullptr),
m_saveContextPolicy(Qt::DefaultContextMenu),
m_inProgressLock(false),
m_qgAnno(nullptr),
m_btnOK(nullptr),
m_btnCancel(nullptr),
m_textDialog(nullptr),
m_rte(nullptr)
m_rte(nullptr),
m_haveMdi(false)
{
// Base::Console().Message("TRA::TRA() - create\n");
if (m_basePage == nullptr) {

4
src/Mod/TechDraw/Gui/TaskSectionView.cpp
View File

@@ -76,7 +76,9 @@ TaskSectionView::TaskSectionView(TechDraw::DrawViewPart* base) :
ui(new Ui_TaskSectionView),
m_base(base),
m_section(nullptr),
m_saveScale(0.0),
m_dirName(""),
m_doc(nullptr),
m_createMode(true),
m_saved(false),
m_abort(false)
@@ -110,6 +112,8 @@ TaskSectionView::TaskSectionView(TechDraw::DrawViewSection* section) :
ui(new Ui_TaskSectionView),
m_base(nullptr),
m_section(section),
m_saveScale(0.0),
m_doc(nullptr),
m_createMode(false),
m_saved(false),
m_abort(false)

8
src/Mod/TechDraw/Gui/TaskWeldingSymbol.cpp
View File

@@ -84,6 +84,10 @@ TaskWeldingSymbol::TaskWeldingSymbol(TechDraw::DrawLeaderLine* leader) :
ui(new Ui_TaskWeldingSymbol),
m_leadFeat(leader),
m_weldFeat(nullptr),
m_arrowFeat(nullptr),
m_otherFeat(nullptr),
m_btnOK(nullptr),
m_btnCancel(nullptr),
m_createMode(true),
m_otherDirty(false)
{
@@ -115,6 +119,10 @@ TaskWeldingSymbol::TaskWeldingSymbol(TechDraw::DrawWeldSymbol* weld) :
ui(new Ui_TaskWeldingSymbol),
m_leadFeat(nullptr),
m_weldFeat(weld),
m_arrowFeat(nullptr),
m_otherFeat(nullptr),
m_btnOK(nullptr),
m_btnCancel(nullptr),
m_createMode(false),
m_otherDirty(false)
{

14
src/Mod/TechDraw/Gui/TaskWeldingSymbol.h
View File

@@ -65,7 +65,7 @@ class MDIViewPage;
class TileImage
{
public:
TileImage() {};
TileImage() { init(); }
~TileImage() = default;
bool toBeSaved;
bool arrowSide;
@@ -82,12 +82,12 @@ public:
arrowSide = true;
row = 0;
col = 0;
leftText = "";
centerText = "";
rightText = "";
symbolPath= "";
symbolString = "";
tileName = "";
leftText.clear();
centerText.clear();
rightText.clear();
symbolPath.clear();
symbolString.clear();
tileName.clear();
}
};

3
src/Mod/TechDraw/Gui/ViewProviderPage.cpp
View File

@@ -87,7 +87,8 @@ PROPERTY_SOURCE(TechDrawGui::ViewProviderPage, Gui::ViewProviderDocumentObject)
ViewProviderPage::ViewProviderPage()
: m_mdiView(0),
m_docReady(true),
m_pageName("")
m_pageName(""),
m_graphicsView(nullptr)
{
sPixmap = "TechDraw_Tree_Page";
static const char *group = "Base";