diff --git a/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp b/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp index fdfb575470..76100f2b0c 100644 --- a/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp +++ b/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp @@ -50,7 +50,7 @@ TaskExtrudeParameters::TaskExtrudeParameters(ViewProviderSketchBased *SketchBase // we need a separate container widget to add all controls to proxy = new QWidget(this); ui->setupUi(proxy); - ui->lineFaceName->setPlaceholderText(tr("No face selected")); + handleLineFaceNameNo(); Gui::ButtonGroup* group = new Gui::ButtonGroup(this); group->addButton(ui->checkBoxMidplane); @@ -683,10 +683,10 @@ void TaskExtrudeParameters::getReferenceAxis(App::DocumentObject*& obj, std::vec void TaskExtrudeParameters::onButtonFace(const bool checked) { - if (!checked && ui->lineFaceName->text().isEmpty()) - ui->lineFaceName->setPlaceholderText(tr("No face selected")); - else if (checked && ui->lineFaceName->text().isEmpty()) - handleLineFaceName(); // sets placeholder text + if (!checked) + handleLineFaceNameNo(); + else + handleLineFaceNameClick(); // sets placeholder text // to distinguish that this is the direction selection selectionFace = true; @@ -892,9 +892,14 @@ void TaskExtrudeParameters::translateModeList(int) // implement in sub-class } -void TaskExtrudeParameters::handleLineFaceName(void) +void TaskExtrudeParameters::handleLineFaceNameClick(void) { ui->lineFaceName->setPlaceholderText(tr("Click on a face in the model")); } +void TaskExtrudeParameters::handleLineFaceNameNo(void) +{ + ui->lineFaceName->setPlaceholderText(tr("No face selected")); +} + #include "moc_TaskExtrudeParameters.cpp" diff --git a/src/Mod/PartDesign/Gui/TaskExtrudeParameters.h b/src/Mod/PartDesign/Gui/TaskExtrudeParameters.h index 658529301b..50b1d99375 100644 --- a/src/Mod/PartDesign/Gui/TaskExtrudeParameters.h +++ b/src/Mod/PartDesign/Gui/TaskExtrudeParameters.h @@ -118,7 +118,8 @@ protected: virtual void updateUI(int index); void updateDirectionEdits(void); void setDirectionMode(int index); - void handleLineFaceName(void); + void handleLineFaceNameClick(void); + void handleLineFaceNameNo(void); private: void tryRecomputeFeature(); diff --git a/src/Mod/PartDesign/Gui/TaskPadParameters.cpp b/src/Mod/PartDesign/Gui/TaskPadParameters.cpp index 608775a76c..df39e51db7 100644 --- a/src/Mod/PartDesign/Gui/TaskPadParameters.cpp +++ b/src/Mod/PartDesign/Gui/TaskPadParameters.cpp @@ -106,7 +106,7 @@ void TaskPadParameters::onModeChanged(int index) pcPad->Type.setValue("UpToFace"); if (ui->lineFaceName->text().isEmpty()) { ui->buttonFace->setChecked(true); - handleLineFaceName(); // sets placeholder text + handleLineFaceNameClick(); // sets placeholder text } break; case Modes::TwoDimensions: diff --git a/src/Mod/PartDesign/Gui/TaskPocketParameters.cpp b/src/Mod/PartDesign/Gui/TaskPocketParameters.cpp index 3412e449fa..85a6b1d338 100644 --- a/src/Mod/PartDesign/Gui/TaskPocketParameters.cpp +++ b/src/Mod/PartDesign/Gui/TaskPocketParameters.cpp @@ -116,7 +116,7 @@ void TaskPocketParameters::onModeChanged(int index) ui->lengthEdit->setValue(0.0); if (ui->lineFaceName->text().isEmpty()) { ui->buttonFace->setChecked(true); - handleLineFaceName(); // sets placeholder text + handleLineFaceNameClick(); // sets placeholder text } break; case Modes::TwoDimensions: