kindred/create
1
1
Fork 0
Code Issues 51 Pull Requests 1 Actions 1 Packages Projects 9 Releases 2 Wiki Activity

[TD]Allow non-shape views to have children (#20768) (#21099)

Browse Source 
* [TD]Allow non-shape views to have children (#20768)

* Update src/Mod/TechDraw/App/DrawView.cpp

Review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/App/DrawView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

---------

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
This commit is contained in:
WandererFan
2025-05-08 10:18:09 -04:00
committed by GitHub
parent 3c25cdc213
commit 9938818d82
4 changed files with 79 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp
View File

@@ -39,6 +39,8 @@
#include <Mod/TechDraw/App/DrawPage.h>
#include <Mod/TechDraw/App/DrawView.h>
#include <Mod/TechDraw/App/DrawViewBalloon.h>
#include <Mod/TechDraw/App/DrawViewDimension.h>
#include <Mod/TechDraw/App/Preferences.h>
#include "ViewProviderDrawingView.h"
@@ -477,3 +479,55 @@ TechDraw::DrawView* ViewProviderDrawingView::getViewObject() const
{
return dynamic_cast<TechDraw::DrawView*>(pcObject);
}
//! it can happen that child graphic items can lose their parent item if the
//! the parent is deleted, then undo is invoked. The linkages on the App side are
//! handled by the undo mechanism, but the QGraphicsScene parentage is not reset.
void ViewProviderDrawingView::fixSceneDependencies()
{
Base::Console().Message("VPDV::fixSceneDependencies()\n");
auto page = getViewProviderPage();
if (!page) {
return;
}
auto scene = page->getQGSPage();
auto ourQView = getQView();
// this is the logic for items other than Dimensions and Balloons
auto children = getViewObject()->getUniqueChildren();
for (auto& child : children) {
if (child->isDerivedFrom<DrawViewDimension>() ||
child->isDerivedFrom<DrawViewBalloon>() ) {
// these are handled by ViewProviderViewPart
continue;
}
auto* childQView = scene->findQViewForDocObj(child);
auto* childGraphicParent = scene->findParent(childQView);
if (childGraphicParent != ourQView) {
scene->addItemToParent(childQView, ourQView);
}
}
}
std::vector<App::DocumentObject*> ViewProviderDrawingView::claimChildren() const
{
std::vector<App::DocumentObject*> temp;
const std::vector<App::DocumentObject *> &potentialChildren = getViewObject()->getInList();
try {
for(auto& child : potentialChildren) {
auto* view = freecad_cast<DrawView *>(child);
if (view && view->claimParent() == getViewObject()) {
temp.push_back(view);
continue;
}
}
}
catch (...) {
return {};
}
return temp;
}