kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

TechDraw: remove double type checking

Browse Source 
Fixes #20131
This commit is contained in:
jonzirk76
2025-03-20 06:03:03 -04:00
committed by Chris Hennes
parent bdf04aafbd
commit 9ac7e6d17c
6 changed files with 21 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/Mod/TechDraw/App/DrawViewClip.cpp
View File

@@ -69,25 +69,15 @@ void DrawViewClip::onChanged(const App::Property* prop)
void DrawViewClip::addView(App::DocumentObject* docObj)
{
if (!docObj->isDerivedFrom<DrawView>() && !docObj->isDerivedFrom<App::Link>()) {
if(docObj->isDerivedFrom<App::Link>()) {
auto* link = static_cast<App::Link*>(docObj);
docObj = link->getLinkedObject();
}
if (!docObj->isDerivedFrom<DrawView>()) {
return;
}
auto* view = dynamic_cast<DrawView*>(docObj);
if (!view) {
auto* link = dynamic_cast<App::Link*>(docObj);
if (!link) {
return;
}
if (link) {
view = dynamic_cast<DrawView*>(link->getLinkedObject());
if (!view) {
return;
}
}
}
auto* view = static_cast<DrawView*>(docObj);
std::vector<App::DocumentObject*> newViews(Views.getValues());
newViews.push_back(docObj);