kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: fix -Wclazy-connect-by-name

Browse Source
This commit is contained in:
wmayer
2023-04-05 15:57:55 +02:00
committed by wwmayer
parent c9c82960ab
commit 9b944f4f20
27 changed files with 413 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/Gui/DlgActionsImp.cpp
View File

@@ -59,6 +59,8 @@ DlgCustomActionsImp::DlgCustomActionsImp( QWidget* parent )
, ui(new Ui_DlgCustomActions)
{
ui->setupUi(this);
setupConnections();
// search for all macros
std::string cMacroPath = App::GetApplication().
GetParameterGroupByPath("User parameter:BaseApp/Preferences/Macro")
@@ -92,6 +94,20 @@ DlgCustomActionsImp::~DlgCustomActionsImp()
MacroCommand::save();
}
void DlgCustomActionsImp::setupConnections()
{
connect(ui->actionListWidget, &QTreeWidget::itemActivated,
this, &DlgCustomActionsImp::onActionListWidgetItemActivated);
connect(ui->buttonChoosePixmap, &QToolButton::clicked,
this, &DlgCustomActionsImp::onButtonChoosePixmapClicked);
connect(ui->buttonAddAction, &QPushButton::clicked,
this, &DlgCustomActionsImp::onButtonAddActionClicked);
connect(ui->buttonRemoveAction, &QPushButton::clicked,
this, &DlgCustomActionsImp::onButtonRemoveActionClicked);
connect(ui->buttonReplaceAction, &QPushButton::clicked,
this, &DlgCustomActionsImp::onButtonReplaceActionClicked);
}
bool DlgCustomActionsImp::event(QEvent* e)
{
bool ok = QWidget::event(e);
@@ -159,7 +175,7 @@ void DlgCustomActionsImp::showActions()
}
}
void DlgCustomActionsImp::on_actionListWidget_itemActivated(QTreeWidgetItem *item)
void DlgCustomActionsImp::onActionListWidgetItemActivated(QTreeWidgetItem *item)
{
if (!item)
return; // no valid item
@@ -210,7 +226,7 @@ void DlgCustomActionsImp::on_actionListWidget_itemActivated(QTreeWidgetItem *ite
}
}
void DlgCustomActionsImp::on_buttonAddAction_clicked()
void DlgCustomActionsImp::onButtonAddActionClicked()
{
if (ui->actionMacros-> currentText().isEmpty())
{
@@ -277,7 +293,7 @@ void DlgCustomActionsImp::on_buttonAddAction_clicked()
Q_EMIT addMacroAction(actionName);
}
void DlgCustomActionsImp::on_buttonReplaceAction_clicked()
void DlgCustomActionsImp::onButtonReplaceActionClicked()
{
QTreeWidgetItem* item = ui->actionListWidget->currentItem();
if (!item)
@@ -353,7 +369,7 @@ void DlgCustomActionsImp::on_buttonReplaceAction_clicked()
item->setIcon(0, Gui::BitmapFactory().pixmap(macro->getPixmap()));
}
void DlgCustomActionsImp::on_buttonRemoveAction_clicked()
void DlgCustomActionsImp::onButtonRemoveActionClicked()
{
// remove item from list view
QTreeWidgetItem* item = ui->actionListWidget->currentItem();
@@ -466,7 +482,7 @@ void IconDialog::onAddIconPath()
}
}
void DlgCustomActionsImp::on_buttonChoosePixmap_clicked()
void DlgCustomActionsImp::onButtonChoosePixmapClicked()
{
// create a dialog showing all pixmaps
Gui::Dialog::IconDialog dlg(this);