kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: fix -Wclazy-connect-by-name

Browse Source
This commit is contained in:
wmayer
2023-04-05 15:57:55 +02:00
committed by wwmayer
parent c9c82960ab
commit 9b944f4f20
27 changed files with 413 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/Gui/DlgToolbarsImp.cpp
View File

@@ -62,6 +62,8 @@ DlgCustomToolbars::DlgCustomToolbars(DlgCustomToolbars::Type t, QWidget* parent)
, type(t)
{
ui->setupUi(this);
setupConnections();
ui->moveActionRightButton->setIcon(BitmapFactory().iconFromTheme("button_right"));
ui->moveActionLeftButton->setIcon(BitmapFactory().iconFromTheme("button_left"));
ui->moveActionDownButton->setIcon(BitmapFactory().iconFromTheme("button_down"));
@@ -107,7 +109,7 @@ DlgCustomToolbars::DlgCustomToolbars(DlgCustomToolbars::Type t, QWidget* parent)
int index = ui->workbenchBox->findData(name);
ui->workbenchBox->setCurrentIndex(index);
}
on_workbenchBox_activated(ui->workbenchBox->currentIndex());
onWorkbenchBoxActivated(ui->workbenchBox->currentIndex());
}
/** Destroys the object and frees any allocated resources */
@@ -115,6 +117,26 @@ DlgCustomToolbars::~DlgCustomToolbars()
{
}
void DlgCustomToolbars::setupConnections()
{
connect(ui->workbenchBox, qOverload<int>(&QComboBox::activated),
this, &DlgCustomToolbars::onWorkbenchBoxActivated);
connect(ui->moveActionRightButton, &QPushButton::clicked,
this, &DlgCustomToolbars::onMoveActionRightButtonClicked);
connect(ui->moveActionLeftButton, &QPushButton::clicked,
this, &DlgCustomToolbars::onMoveActionLeftButtonClicked);
connect(ui->moveActionUpButton, &QPushButton::clicked,
this, &DlgCustomToolbars::onMoveActionUpButtonClicked);
connect(ui->moveActionDownButton, &QPushButton::clicked,
this, &DlgCustomToolbars::onMoveActionDownButtonClicked);
connect(ui->newButton, &QPushButton::clicked,
this, &DlgCustomToolbars::onNewButtonClicked);
connect(ui->renameButton, &QPushButton::clicked,
this, &DlgCustomToolbars::onRenameButtonClicked);
connect(ui->deleteButton, &QPushButton::clicked,
this, &DlgCustomToolbars::onDeleteButtonClicked);
}
void DlgCustomToolbars::addCustomToolbar(const QString&)
{
}
@@ -156,7 +178,7 @@ void DlgCustomToolbars::onActivateCategoryBox()
{
}
void DlgCustomToolbars::on_workbenchBox_activated(int index)
void DlgCustomToolbars::onWorkbenchBoxActivated(int index)
{
QVariant data = ui->workbenchBox->itemData(index, Qt::UserRole);
QString workbench = data.toString();
@@ -270,7 +292,7 @@ void DlgCustomToolbars::exportCustomToolbars(const QByteArray& workbench)
}
/** Adds a new action */
void DlgCustomToolbars::on_moveActionRightButton_clicked()
void DlgCustomToolbars::onMoveActionRightButtonClicked()
{
QTreeWidgetItem* item = ui->commandTreeWidget->currentItem();
if (item) {
@@ -296,7 +318,7 @@ void DlgCustomToolbars::on_moveActionRightButton_clicked()
}
/** Removes an action */
void DlgCustomToolbars::on_moveActionLeftButton_clicked()
void DlgCustomToolbars::onMoveActionLeftButtonClicked()
{
QTreeWidgetItem* item = ui->toolbarTreeWidget->currentItem();
if (item && item->parent() && item->isSelected()) {
@@ -330,7 +352,7 @@ void DlgCustomToolbars::on_moveActionLeftButton_clicked()
}
/** Moves up an action */
void DlgCustomToolbars::on_moveActionUpButton_clicked()
void DlgCustomToolbars::onMoveActionUpButtonClicked()
{
QTreeWidgetItem* item = ui->toolbarTreeWidget->currentItem();
if (item && item->parent() && item->isSelected()) {
@@ -368,7 +390,7 @@ void DlgCustomToolbars::on_moveActionUpButton_clicked()
}
/** Moves down an action */
void DlgCustomToolbars::on_moveActionDownButton_clicked()
void DlgCustomToolbars::onMoveActionDownButtonClicked()
{
QTreeWidgetItem* item = ui->toolbarTreeWidget->currentItem();
if (item && item->parent() && item->isSelected()) {
@@ -405,7 +427,7 @@ void DlgCustomToolbars::on_moveActionDownButton_clicked()
exportCustomToolbars(workbench.toLatin1());
}
void DlgCustomToolbars::on_newButton_clicked()
void DlgCustomToolbars::onNewButtonClicked()
{
bool ok;
QString text = QString::fromLatin1("Custom%1").arg(ui->toolbarTreeWidget->topLevelItemCount()+1);
@@ -433,7 +455,7 @@ void DlgCustomToolbars::on_newButton_clicked()
}
}
void DlgCustomToolbars::on_deleteButton_clicked()
void DlgCustomToolbars::onDeleteButtonClicked()
{
QTreeWidgetItem* item = ui->toolbarTreeWidget->currentItem();
if (item && !item->parent() && item->isSelected()) {
@@ -448,7 +470,7 @@ void DlgCustomToolbars::on_deleteButton_clicked()
exportCustomToolbars(workbench.toLatin1());
}
void DlgCustomToolbars::on_renameButton_clicked()
void DlgCustomToolbars::onRenameButtonClicked()
{
bool renamed = false;
QTreeWidgetItem* item = ui->toolbarTreeWidget->currentItem();