From 9cbfe835f33a1ee40c5b159d6c4270377e8dcaa3 Mon Sep 17 00:00:00 2001 From: Chris Hennes Date: Mon, 11 Oct 2021 21:13:22 -0500 Subject: [PATCH] [Tools] Eliminate default value modification LGTM catches a potential error with the mutation of default values: implement their suggested workaround of using a None placeholder to ensure the default itself is never modified. --- src/Tools/generateBase/generateTools.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Tools/generateBase/generateTools.py b/src/Tools/generateBase/generateTools.py index d6d6ad92b1..2e4efa3243 100644 --- a/src/Tools/generateBase/generateTools.py +++ b/src/Tools/generateBase/generateTools.py @@ -100,12 +100,15 @@ class copier: except TypeError: self.ouf.write(self.regex.sub(repl, line)) i=i+1 - def __init__(self, regex=_never, dict={}, + def __init__(self, regex=_never, dict=None, restat=_never, restend=_never, recont=_never, preproc=identity, handle=nohandle, ouf=sys.stdout): "Initialize self's attributes" self.regex = regex - self.globals = dict + if dict is not None: + self.globals = dict + else: + self.globals = {} self.globals['sys'] = sys self.locals = { '_cb':self.copyblock } self.restat = restat