Added some comments about things to be fixed in the future
This commit is contained in:
committed by
Stefan Tröger
parent
010761d162
commit
9dba4c01e2
@@ -628,8 +628,10 @@ void SketchBased::generatePrism(TopoDS_Shape& prism,
|
||||
const bool SketchBased::checkWireInsideFace(const TopoDS_Wire& wire, const TopoDS_Face& face,
|
||||
const gp_Dir& dir) {
|
||||
// Project wire onto the face (face, not surface! So limits of face apply)
|
||||
// FIXME: For a user-selected upToFace, sometimes this returns a non-closed wire for no apparent reason
|
||||
// Check again after introduction of "robust" reference for upToFace
|
||||
// FIXME: The results of BRepProj_Projection do not seem to be very stable. Sometimes they return no result
|
||||
// even in the simplest projection case.
|
||||
// FIXME: Checking for Closed() is wrong because this has nothing to do with the wire itself being closed
|
||||
// But ShapeAnalysis_Wire::CheckClosed() doesn't give correct results either.
|
||||
BRepProj_Projection proj(wire, face, dir);
|
||||
return (proj.More() && proj.Current().Closed());
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user