From 9efd6baee927c98fb06eaa9aaa6e5cb3cbfab99b Mon Sep 17 00:00:00 2001
From: Benjamin Nauck <benjamin@nauck.se>
Date: Mon, 19 May 2025 19:55:14 +0200
Subject: [PATCH] Base: Fix use after free in unit error message

---
 src/Base/UnitsApiPy.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/Base/UnitsApiPy.cpp b/src/Base/UnitsApiPy.cpp
index 7efd122c2d..799ca43ad4 100644
--- a/src/Base/UnitsApiPy.cpp
+++ b/src/Base/UnitsApiPy.cpp
@@ -89,9 +89,7 @@ PyObject* UnitsApi::sParseQuantity(PyObject* /*self*/, PyObject* args)
         return new QuantityPy(new Quantity(Quantity::parse(str)));
     }
     catch (const ParserError&) {
-        PyErr_Format(PyExc_ValueError,
-                     "invalid unit expression: '%s'\n",
-                     std::string {pstr}.c_str());
+        PyErr_Format(PyExc_ValueError, "invalid unit expression: '%s'\n", str.c_str());
         return nullptr;
     }
 }