From a0731a0d8647f877de7a77cb41cb1a4e55db68f5 Mon Sep 17 00:00:00 2001 From: Uwe Date: Wed, 15 Feb 2023 14:22:01 +0100 Subject: [PATCH] [FEM] Contours: disable keyboard tracking - otherwise the contour creating algorithm would be invoked on every keystroke - also improve a code comment --- src/Mod/Fem/Gui/TaskPostContours.ui | 3 +++ src/Mod/Fem/Gui/ViewProviderFemPostObject.cpp | 24 +++++++++---------- 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/src/Mod/Fem/Gui/TaskPostContours.ui b/src/Mod/Fem/Gui/TaskPostContours.ui index f6fba0688e..9e62a3466e 100644 --- a/src/Mod/Fem/Gui/TaskPostContours.ui +++ b/src/Mod/Fem/Gui/TaskPostContours.ui @@ -60,6 +60,9 @@ Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + false + 1 diff --git a/src/Mod/Fem/Gui/ViewProviderFemPostObject.cpp b/src/Mod/Fem/Gui/ViewProviderFemPostObject.cpp index ed4c204ef5..7cd58a0cd0 100644 --- a/src/Mod/Fem/Gui/ViewProviderFemPostObject.cpp +++ b/src/Mod/Fem/Gui/ViewProviderFemPostObject.cpp @@ -628,21 +628,21 @@ void ViewProviderFemPostObject::updateData(const App::Property* p) { void ViewProviderFemPostObject::filterArtifacts(vtkDataObject* data) { - // The problem is that in the surface view the boundary reagions of the volumess + // The problem is that in the surface view the boundary regions of the volumes // calculated by the different CPU cores is always visible, independent of the - // transparency setting. Elmer is not to blame, this is just a property of the - // partial VTK file reader. So this can happen with various input + // transparency setting. Elmer is not to blame because this is a property of the + // partial VTK file reader. So this can happen with various inputs // since FreeCAD can also be used to view VTK files without the need to perform - // an analysis. Therefore it is impossible to know in advance when to filter - // or not. - // Only for pure CCX analyses we know that no filtering is necessary. - // However, the effort to catch this case is not worth it since the filtering - // is only as time-consuming as enabling the surface filter. In fact, it is like - // performing the surface flter twice. + // an analysis. Therefore it is impossible to know in advance when a filter + // is necessary or not. + // Only for pure CCX analyses we know that no filtering is necessary. However, + // the effort to catch this case is not worth it since the filtering is + // only as time-consuming as enabling the surface filter. In fact, it is like + // performing the surface filter twice. - // We need to set the filter clipping plane below the z minimum of the data. - // We can either do this by checkting the VTK data or by getting the info from - // the 3D view. We use here the latter because this much faster. + // We need to set the filter clipping plane below the z-minimum of the data. + // We can either do this by checking the VTK data or by getting the info from + // the 3D view. We use here the latter because this is much faster. // since we will set the filter according to the visible bounding box // assure the object is visible