From a0d6310658dca71113611c173d7fb6ee77155a8c Mon Sep 17 00:00:00 2001 From: wmayer Date: Sun, 20 Mar 2022 16:42:48 +0100 Subject: [PATCH] App: [skip ci] lgtm: Large object passed by value This parameter of type pair, allocator>, Metadata> is 672 bytes - consider passing a const pointer/reference instead. --- src/App/Metadata.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/App/Metadata.cpp b/src/App/Metadata.cpp index ce0796bf7b..96aa4b8236 100644 --- a/src/App/Metadata.cpp +++ b/src/App/Metadata.cpp @@ -345,7 +345,7 @@ void App::Metadata::addGenericMetadata(const std::string& tag, const Meta::Gener void App::Metadata::removeContentItem(const std::string& tag, const std::string& itemName) { auto tagRange = _content.equal_range(tag); - auto foundItem = std::find_if(tagRange.first, tagRange.second, [&itemName](auto check) -> bool { return itemName == check.second.name(); }); + auto foundItem = std::find_if(tagRange.first, tagRange.second, [&itemName](const auto& check) -> bool { return itemName == check.second.name(); }); if (foundItem != tagRange.second) _content.erase(foundItem); }