From a1e89da8fd6a6ff987273eb98aa4228862b82ec3 Mon Sep 17 00:00:00 2001
From: vocx-fc <vocx-fc@users.noreply.github.com>
Date: Thu, 15 Oct 2020 18:46:55 -0500
Subject: [PATCH] Sketcher: add BSplineDecreaseDegree although with an empty
 implementation

Currently there is a command to increase the degree of a B-spline
but the corresponding command to reduce the degree does not exist.
So this command is a placeholder for when the full implementation
is added in the future by somebody.
---
 .../Sketcher/Gui/CommandSketcherBSpline.cpp   | 40 ++++++++++++++-----
 src/Mod/Sketcher/Gui/Workbench.cpp            |  4 +-
 2 files changed, 32 insertions(+), 12 deletions(-)

diff --git a/src/Mod/Sketcher/Gui/CommandSketcherBSpline.cpp b/src/Mod/Sketcher/Gui/CommandSketcherBSpline.cpp
index 4e71d011f9..c6991d9565 100644
--- a/src/Mod/Sketcher/Gui/CommandSketcherBSpline.cpp
+++ b/src/Mod/Sketcher/Gui/CommandSketcherBSpline.cpp
@@ -470,15 +470,36 @@ bool CmdSketcherIncreaseDegree::isActive(void)
 }
 
 
-// TODO: implement this function to complement Sketcher_BSplineIncreaseDegree
-
 // Decrease degree of the spline
-// DEF_STD_CMD_A(CmdSketcherDecreaseDegree)
-// CmdSketcherDecreaseDegree::CmdSketcherDecreaseDegree()
-// : Command("Sketcher_BSplineDecreaseDegree")
-// {
-// ...
-// }
+DEF_STD_CMD_A(CmdSketcherDecreaseDegree)
+
+CmdSketcherDecreaseDegree::CmdSketcherDecreaseDegree()
+    : Command("Sketcher_BSplineDecreaseDegree")
+{
+    sAppModule      = "Sketcher";
+    sGroup          = QT_TR_NOOP("Sketcher");
+    sMenuText       = QT_TR_NOOP("Decrease B-spline degree");
+    sToolTipText    = QT_TR_NOOP("Decreases the degree of the B-spline.\n"
+                                 "This command is currently NOT IMPLEMENTED.");
+    sWhatsThis      = "Sketcher_BSplineDecreaseDegree";
+    sStatusTip      = sToolTipText;
+    sPixmap         = "Sketcher_BSplineDecreaseDegree";
+    sAccel          = "";
+    eType           = ForEdit;
+}
+
+// TODO: fully implement this function to complement Sketcher_BSplineIncreaseDegree
+void CmdSketcherDecreaseDegree::activated(int iMsg)
+{
+    Q_UNUSED(iMsg);
+    Base::Console().Message("Decrease degree of spline. "
+                            "This command is currently NOT IMPLEMENTED.\n");
+}
+
+bool CmdSketcherDecreaseDegree::isActive(void)
+{
+    return isSketcherBSplineActive(getActiveGuiDocument(), true);
+}
 
 
 DEF_STD_CMD_A(CmdSketcherIncreaseKnotMultiplicity)
@@ -881,8 +902,7 @@ void CreateSketcherCommandsBSpline(void)
     rcCmdMgr.addCommand(new CmdSketcherCompBSplineShowHideGeometryInformation());
     rcCmdMgr.addCommand(new CmdSketcherConvertToNURB());
     rcCmdMgr.addCommand(new CmdSketcherIncreaseDegree());
-    // TODO: implement this function to complement CmdSketcherIncreaseDegree
-    // rcCmdMgr.addCommand(new CmdSketcherDecreaseDegree());
+    rcCmdMgr.addCommand(new CmdSketcherDecreaseDegree());  // TODO: implement this function
     rcCmdMgr.addCommand(new CmdSketcherIncreaseKnotMultiplicity());
     rcCmdMgr.addCommand(new CmdSketcherDecreaseKnotMultiplicity());
     rcCmdMgr.addCommand(new CmdSketcherCompModifyKnotMultiplicity());
diff --git a/src/Mod/Sketcher/Gui/Workbench.cpp b/src/Mod/Sketcher/Gui/Workbench.cpp
index f90d0099eb..4357172ebf 100644
--- a/src/Mod/Sketcher/Gui/Workbench.cpp
+++ b/src/Mod/Sketcher/Gui/Workbench.cpp
@@ -373,7 +373,7 @@ inline void SketcherAddWorkbenchBSplines<Gui::MenuItem>(Gui::MenuItem& bspline)
         << "Sketcher_BSplineKnotMultiplicity"
         << "Sketcher_BSplineConvertToNURB"
         << "Sketcher_BSplineIncreaseDegree"
-        // << "Sketcher_BSplineDecreaseDegree" TODO: implement this
+        << "Sketcher_BSplineDecreaseDegree"  // TODO: implement this command
         << "Sketcher_BSplineIncreaseKnotMultiplicity"
         << "Sketcher_BSplineDecreaseKnotMultiplicity";
 }
@@ -384,7 +384,7 @@ inline void SketcherAddWorkbenchBSplines<Gui::ToolBarItem>(Gui::ToolBarItem& bsp
     bspline << "Sketcher_CompBSplineShowHideGeometryInformation"
     << "Sketcher_BSplineConvertToNURB"
     << "Sketcher_BSplineIncreaseDegree"
-    // << "Sketcher_BSplineDecreaseDegree" TODO: implement this
+    << "Sketcher_BSplineDecreaseDegree"  // TODO: implement this command
     << "Sketcher_CompModifyKnotMultiplicity";
 }