kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[FEM] fix a variable casting

Browse Source 
- reported by MSVC not to cast a float to a double but as double directly

- also remove some superfluous Boolean comparisons
This commit is contained in:
Uwe
2022-06-15 03:35:11 +02:00
parent 4f03c996bd
commit a289ec4a06
3 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Mod/Fem/Gui/ViewProviderFemPostObject.cpp
View File

@@ -449,8 +449,8 @@ void ViewProviderFemPostObject::setRangeOfColorBar(double min, double max)
{
try {
if (min >= max) {
min = max - 10 * std::numeric_limits<float>::epsilon();
max = max + 10 * std::numeric_limits<float>::epsilon();
min = max - 10 * std::numeric_limits<double>::epsilon();
max = max + 10 * std::numeric_limits<double>::epsilon();
}
m_colorBar->setRange(min, max);
}
@@ -465,7 +465,6 @@ void ViewProviderFemPostObject::WriteColorData(bool ResetColorBarRange) {
return;
if (Field.getEnumVector().empty() || Field.getValue() == 0) {
m_material->diffuseColor.setValue(SbColor(0.8, 0.8, 0.8));
m_material->transparency.setValue(0.);
m_materialBinding->value = SoMaterialBinding::OVERALL;
@@ -473,7 +472,6 @@ void ViewProviderFemPostObject::WriteColorData(bool ResetColorBarRange) {
return;
};
int array = Field.getValue() - 1; //0 is none
vtkPolyData* pd = m_currentAlgorithm->GetOutput();
vtkDataArray* data = pd->GetPointData()->GetArray(array);
@@ -483,7 +481,7 @@ void ViewProviderFemPostObject::WriteColorData(bool ResetColorBarRange) {
component = 0;
//build the lookuptable
if (ResetColorBarRange == true) {
if (ResetColorBarRange) {
double range[2];
data->GetRange(range, component);
setRangeOfColorBar(range[0], range[1]);
@@ -591,7 +589,7 @@ bool ViewProviderFemPostObject::doubleClicked(void) {
// check if backlight is enabled
ParameterGrp::handle hGrp = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/View");
bool isBackLightEnabled = hGrp->GetBool("EnableBacklight", false);
if (isBackLightEnabled == false)
if (!isBackLightEnabled)
Base::Console().Error("Backlight is not enabled. Due to a VTK implementation problem you really should consider to enable backlight in FreeCAD display preferences if you work with VTK post processing.\n");
// set edit
Gui::Application::Instance->activeDocument()->setEdit(this, (int)ViewProvider::Default);