kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Revert "Address the poor performance of the existing unique-name generation (#17944)"

Browse Source 
This reverts commit 83202d8ad6.

# Conflicts:
#	src/Base/Tools.cpp
#	src/Base/Tools.h
This commit is contained in:
Benjamin Nauck
2024-12-16 14:30:49 +01:00
committed by Yorik van Havre
parent 844d88fb7a
commit a2c980f7d6
28 changed files with 430 additions and 716 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Mod/Spreadsheet/App/Sheet.cpp
View File

@@ -872,17 +872,6 @@ void Sheet::getPropertyNamedList(std::vector<std::pair<const char*, Property*>>&
}
}
void Sheet::visitProperties(std::function<void(App::Property*)> visitor) const
{
DocumentObject::visitProperties(visitor);
for (const auto& v : cells.aliasProp) {
auto prop = getProperty(v.first);
if (prop != nullptr) {
visitor(prop);
}
};
}
void Sheet::touchCells(Range range)
{
do {
@@ -1145,7 +1134,7 @@ DocumentObjectExecReturn* Sheet::execute()
catch (std::exception&) { // TODO: evaluate using a more specific exception (not_a_dag)
// Cycle detected; flag all with errors
Base::Console().Error("Cyclic dependency detected in spreadsheet : %s\n",
getNameInDocument());
*pcNameInDocument);
std::ostringstream ss;
ss << "Cyclic dependency";
int count = 0;

3
src/Mod/Spreadsheet/App/Sheet.h
View File

@@ -189,9 +189,6 @@ public:
void
getPropertyNamedList(std::vector<std::pair<const char*, App::Property*>>& List) const override;
/// See PropertyContainer::visitProperties for semantics
void visitProperties(std::function<void(App::Property*)> visitor) const override;
short mustExecute() const override;
App::DocumentObjectExecReturn* execute() override;