kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Toponaming: Update tests, implement missing subtractive operation tests,

Browse Source 
fix helix and revolution
This commit is contained in:
bgbsww
2024-07-28 21:18:56 -04:00
committed by Chris Hennes
parent f03f4ace11
commit a348a1bc82
10 changed files with 283 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Mod/PartDesign/App/FeaturePipe.cpp
View File

@@ -690,8 +690,7 @@ App::DocumentObjectExecReturn *Pipe::execute()
sewer.Add(s);
sewer.Perform();
mkSolid.Add(TopoDS::Shell(sewer.SewedShape()));
} else {
mkSolid.Add(TopoDS::Shell(sewer.SewedShape())); } else {
// shells are already closed - add them directly
for (TopoDS_Shape& s : shells) {
mkSolid.Add(TopoDS::Shell(s));
@@ -709,15 +708,15 @@ App::DocumentObjectExecReturn *Pipe::execute()
}
//result.Move(invObjLoc);
AddSubShape.setValue(result); // TODO: Do we need to toposhape here?
AddSubShape.setValue(result); // Converts result to a TopoShape, but no tag.
if (base.isNull()) {
if (getAddSubType() == FeatureAddSub::Subtractive)
return new App::DocumentObjectExecReturn(
QT_TRANSLATE_NOOP("Exception", "Pipe: There is nothing to subtract from"));
result = refineShapeIfActive(result);
Shape.setValue(getSolid(result));
auto ts_result = refineShapeIfActive(result);
Shape.setValue(getSolid(ts_result));
return App::DocumentObject::StdReturn;
}