From a3e436d211c33378db42a195dfd641f2b622863f Mon Sep 17 00:00:00 2001 From: Chris Hennes Date: Fri, 7 Feb 2025 10:17:16 -0600 Subject: [PATCH] Addon Manager: Update background UI earlier The modal confirmation dialog blocks, so update the UI before showing it. --- ...addonmanager_package_details_controller.py | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/Mod/AddonManager/addonmanager_package_details_controller.py b/src/Mod/AddonManager/addonmanager_package_details_controller.py index 9d84e8055d..ccd97a2e7f 100644 --- a/src/Mod/AddonManager/addonmanager_package_details_controller.py +++ b/src/Mod/AddonManager/addonmanager_package_details_controller.py @@ -248,18 +248,6 @@ class PackageDetailsController(QtCore.QObject): def branch_changed(self, old_branch: str, name: str) -> None: """Displays a dialog confirming the branch changed, and tries to access the metadata file from that branch.""" - QtWidgets.QMessageBox.information( - self.ui, - translate("AddonsInstaller", "Success"), - translate( - "AddonsInstaller", - "Branch change succeeded.\n" - "Moved\n" - "from: {}\n" - "to: {}\n" - "Please restart to use the new version.", - ).format(old_branch, name), - ) # See if this branch has a package.xml file: basedir = fci.getUserAppDataDir() path_to_metadata = os.path.join(basedir, "Mod", self.addon.name, "package.xml") @@ -275,6 +263,18 @@ class PackageDetailsController(QtCore.QObject): self.addon.set_status(Addon.Status.PENDING_RESTART) self.ui.set_new_branch(name) self.update_status.emit(self.addon) + QtWidgets.QMessageBox.information( + self.ui, + translate("AddonsInstaller", "Success"), + translate( + "AddonsInstaller", + "Branch change succeeded.\n" + "Moved\n" + "from: {}\n" + "to: {}\n" + "Please restart to use the new version.", + ).format(old_branch, name), + ) def display_repo_status(self, addon): self.update_status.emit(self.addon)