From a45e2ae8a4982ad5f40933c5c6079291f52a596f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Benjamin=20Br=C3=A6strup=20Sayoc?= Date: Sun, 2 Feb 2025 22:26:17 +0100 Subject: [PATCH] Remove magic number and hard type enums in BalloonPropEnum.h - Remove currently present magic numbers - Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers. --- src/Mod/TechDraw/App/BalloonPropEnum.h | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/Mod/TechDraw/App/BalloonPropEnum.h b/src/Mod/TechDraw/App/BalloonPropEnum.h index d2ce78a760..f60ddb014d 100644 --- a/src/Mod/TechDraw/App/BalloonPropEnum.h +++ b/src/Mod/TechDraw/App/BalloonPropEnum.h @@ -33,14 +33,16 @@ namespace TechDraw { -enum BalloonType { Circular = 0, - None, - Triangle, - Inspection, - Hexagon, - Square, - Rectangle, - Line}; +enum class BalloonType { + Circular = 0, + None, + Triangle, + Inspection, + Hexagon, + Square, + Rectangle, + Line +}; class TechDrawExport BalloonPropEnum { Q_DECLARE_TR_FUNCTIONS(TechDraw::BalloonPropEnum)