From a46e495c3d5fe70f5da2bf0cd2c34a600031c9c0 Mon Sep 17 00:00:00 2001
From: Bernd Hahnebach <bernd@bimstatik.org>
Date: Tue, 6 Jun 2017 16:55:18 +0100
Subject: [PATCH] FEM: gmsh mesh tool, get rid of the error pop up in the
 regard of BooleanFragments Compound

---
 src/Mod/Fem/FemGmshTools.py                | 19 ++++++++++++-------
 src/Mod/Fem/PyGui/_TaskPanelFemMeshGmsh.py | 14 ++++++--------
 2 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/src/Mod/Fem/FemGmshTools.py b/src/Mod/Fem/FemGmshTools.py
index 66b3a0dc55..1bb34ca0c7 100644
--- a/src/Mod/Fem/FemGmshTools.py
+++ b/src/Mod/Fem/FemGmshTools.py
@@ -147,9 +147,8 @@ class FemGmshTools():
                 FreeCAD.Console.PrintError("You can not mesh a Vertex.\n")
                 self.dimension = '0'
             elif shty == 'Compound':
-                print('  Found a ' + shty)
-                err = "A Compound could contain anything. GMSH may not return the expected mesh. It is strongly recommended to extract the shape to mesh from the Compound and use this one."
-                FreeCAD.Console.PrintError(err + "\n")
+                # print('  Found a ' + shty)
+                FreeCAD.Console.PrintLog("  Found a Compound. Since it could contain any kind of shape dimension 3 is used.\n")
                 self.dimension = '3'  # dimension 3 works for 2D and 1d shapes as well
             else:
                 self.dimension = '0'
@@ -252,10 +251,16 @@ class FemGmshTools():
             print ('  No mesh regions.')
         else:
             print ('  Mesh regions, we need to get the elements.')
-            if self.part_obj.Shape.ShapeType == 'Compound':
-                # see http://forum.freecadweb.org/viewtopic.php?f=18&t=18780&start=40#p149467 and http://forum.freecadweb.org/viewtopic.php?f=18&t=18780&p=149520#p149520
-                err = "GMSH could return unexpected meshes for a boolean split tools Compound. It is strongly recommended to extract the shape to mesh from the Compound and use this one."
-                FreeCAD.Console.PrintError(err + "\n")
+            # by the use of MeshRegion object and a BooleanSplitCompound there could be problems with node numbers see
+            # http://forum.freecadweb.org/viewtopic.php?f=18&t=18780&start=40#p149467
+            # http://forum.freecadweb.org/viewtopic.php?f=18&t=18780&p=149520#p149520
+            part = self.part_obj
+            if self.mesh_obj.MeshRegionList:
+                if part.Shape.ShapeType == "Compound" and hasattr(part, "Proxy"):  # other part obj might not have a Proxy, thus an exception would be raised
+                    if (part.Proxy.Type == "FeatureBooleanFragments" or part.Proxy.Type == "FeatureSlice" or part.Proxy.Type == "FeatureXOR"):
+                        error_message = "  The mesh to shape is a boolean split tools Compound and the mesh has mesh region list. GMSH could return unexpected meshes in such circumstances. It is strongly recommended to extract the shape to mesh from the Compound and use this one."
+                        FreeCAD.Console.PrintError(error_message + "\n")
+                        # TODO no gui popup because FreeCAD will be in a endless prind loop as long as the pop up is on --> my be find a better solution for either of both --> thus the pop up is in task panel
             for mr_obj in self.mesh_obj.MeshRegionList:
                 # print(mr_obj.Name)
                 # print(mr_obj.CharacteristicLength)
diff --git a/src/Mod/Fem/PyGui/_TaskPanelFemMeshGmsh.py b/src/Mod/Fem/PyGui/_TaskPanelFemMeshGmsh.py
index d1fe71dfb5..bb1ff31003 100644
--- a/src/Mod/Fem/PyGui/_TaskPanelFemMeshGmsh.py
+++ b/src/Mod/Fem/PyGui/_TaskPanelFemMeshGmsh.py
@@ -125,14 +125,12 @@ class _TaskPanelFemMeshGmsh:
 
     def run_gmsh(self):
         QApplication.setOverrideCursor(Qt.WaitCursor)
-        partsh = self.obj.Part
-        if partsh.Shape.ShapeType == "Compound":
-            error_message = "The mesh to shape is a Compound, GMSH could return unexpected meshes for Compounds. It is strongly recommended to extract the shape to mesh from the Compound and use this one."
-            FreeCAD.Console.PrintError(error_message + "\n")
-            if hasattr(partsh, "Proxy") and (partsh.Proxy.Type == "FeatureBooleanFragments" or partsh.Proxy.Type == "FeatureSlice" or partsh.Proxy.Type == "FeatureXOR"):  # other part obj might not have a Proxy
-                error_message = "The mesh to shape is a boolean split tools Compound, GMSH could return unexpected meshes for a boolean split tools Compound. It is strongly recommended to extract the shape to mesh from the Compound and use this one."
-                FreeCAD.Console.PrintError(error_message + "\n")
-                QtGui.QMessageBox.critical(None, "Shape to mesh is a Compound", error_message)
+        part = self.obj.Part
+        if self.mesh_obj.MeshRegionList:
+            if part.Shape.ShapeType == "Compound" and hasattr(part, "Proxy"):  # other part obj might not have a Proxy, thus an exception would be raised
+                if (part.Proxy.Type == "FeatureBooleanFragments" or part.Proxy.Type == "FeatureSlice" or part.Proxy.Type == "FeatureXOR"):
+                    error_message = "The mesh to shape is a boolean split tools Compound and the mesh has mesh region list. GMSH could return unexpected meshes in such circumstances. It is strongly recommended to extract the shape to mesh from the Compound and use this one."
+                    QtGui.QMessageBox.critical(None, "Shape to mesh is a BooleanFragmentsCompound and mesh regions are defined", error_message)
         self.Start = time.time()
         self.form.l_time.setText('Time: {0:4.1f}: '.format(time.time() - self.Start))
         self.console_message_gmsh = ''