From a52ab499c0e215bbed484d8cbac75600e137ac91 Mon Sep 17 00:00:00 2001
From: bitacovir <bitacovir@gmail.com>
Date: Sun, 16 Aug 2020 21:32:52 -0400
Subject: [PATCH] Add SVG icon for Mesh FillupHoles command in MeshWB

Many Mesh Design Workbench commands do not have icons. The Mesh FillupHoles command is one of these without a SVG icon for the FreeCAD UI.

This commit adds a SVG file with an icon design for this command. Also, it makes the necessary changes on Command.cpp and Mesh.qrc files.

The new SVG icon follows the FreeCAD Artwork Guidelines:
https://www.freecadweb.org/wiki/Artwork_Guidelines

The icon design keep the style of the existing icons in the Mesh Workbench:
https://wiki.freecadweb.org/Mesh_Workbench

The discussion with the project for a set of SVG icons for the Mesh Design Workbench can be found in the UX/UI Design FreeCAD Forum:
https://forum.freecadweb.org/viewtopic.php?f=34&t=47494
---
 src/Mod/Mesh/Gui/Command.cpp                  |   1 +
 src/Mod/Mesh/Gui/Resources/Mesh.qrc           |   1 +
 .../Resources/icons/Mesh_Fill_up_Holes.svg    | 220 ++++++++++++++++++
 3 files changed, 222 insertions(+)
 create mode 100644 src/Mod/Mesh/Gui/Resources/icons/Mesh_Fill_up_Holes.svg

diff --git a/src/Mod/Mesh/Gui/Command.cpp b/src/Mod/Mesh/Gui/Command.cpp
index ca2c317d1e..30be1be365 100644
--- a/src/Mod/Mesh/Gui/Command.cpp
+++ b/src/Mod/Mesh/Gui/Command.cpp
@@ -1619,6 +1619,7 @@ CmdMeshFillupHoles::CmdMeshFillupHoles()
     sToolTipText  = QT_TR_NOOP("Fill holes of the mesh");
     sWhatsThis    = "Mesh_FillupHoles";
     sStatusTip    = QT_TR_NOOP("Fill holes of the mesh");
+    sPixmap       = "Mesh_Fill_up_Holes";
 }
 
 void CmdMeshFillupHoles::activated(int)
diff --git a/src/Mod/Mesh/Gui/Resources/Mesh.qrc b/src/Mod/Mesh/Gui/Resources/Mesh.qrc
index 74e6bfb2fc..87b8d656ac 100644
--- a/src/Mod/Mesh/Gui/Resources/Mesh.qrc
+++ b/src/Mod/Mesh/Gui/Resources/Mesh.qrc
@@ -14,6 +14,7 @@
         <file>icons/Mesh_Remove_Components.svg</file>
         <file>icons/Mesh_Tree_Curvature_Plot.svg</file>
         <file>icons/MeshWorkbench.svg</file>
+        <file>icons/Mesh_Fill_up_Holes.svg</file>
         <file>icons/RegularSolids/Mesh_Cone.svg</file>
         <file>icons/RegularSolids/Mesh_Cube.svg</file>
         <file>icons/RegularSolids/Mesh_Cylinder.svg</file>
diff --git a/src/Mod/Mesh/Gui/Resources/icons/Mesh_Fill_up_Holes.svg b/src/Mod/Mesh/Gui/Resources/icons/Mesh_Fill_up_Holes.svg
new file mode 100644
index 0000000000..bde662e2f7
--- /dev/null
+++ b/src/Mod/Mesh/Gui/Resources/icons/Mesh_Fill_up_Holes.svg
@@ -0,0 +1,220 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<svg
+   xmlns:dc="http://purl.org/dc/elements/1.1/"
+   xmlns:cc="http://creativecommons.org/ns#"
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
+   xmlns:svg="http://www.w3.org/2000/svg"
+   xmlns="http://www.w3.org/2000/svg"
+   xmlns:xlink="http://www.w3.org/1999/xlink"
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
+   version="1.1"
+   inkscape:output_extension="org.inkscape.output.svg.inkscape"
+   sodipodi:docname="Mesh_Fill_Holes.svg"
+   inkscape:version="1.0 (4035a4fb49, 2020-05-01)"
+   sodipodi:version="0.32"
+   id="svg9484"
+   height="64"
+   width="64">
+  <title
+     id="title3749">Mesh_Fill_Up_Holes</title>
+  <defs
+     id="defs9486">
+    <linearGradient
+       inkscape:collect="always"
+       id="linearGradient860">
+      <stop
+         style="stop-color:#4e9a06;stop-opacity:1"
+         offset="0"
+         id="stop856" />
+      <stop
+         style="stop-color:#8ae234;stop-opacity:1"
+         offset="1"
+         id="stop858" />
+    </linearGradient>
+    <linearGradient
+       inkscape:collect="always"
+       id="linearGradient852">
+      <stop
+         style="stop-color:#4e9a06;stop-opacity:1"
+         offset="0"
+         id="stop848" />
+      <stop
+         style="stop-color:#8ae234;stop-opacity:1"
+         offset="1"
+         id="stop850" />
+    </linearGradient>
+    <linearGradient
+       id="linearGradient12537"
+       inkscape:collect="always">
+      <stop
+         id="stop12539"
+         offset="0"
+         style="stop-color:#00fd00;stop-opacity:1;" />
+      <stop
+         id="stop12541"
+         offset="1"
+         style="stop-color:#00fd00;stop-opacity:0;" />
+    </linearGradient>
+    <linearGradient
+       gradientTransform="translate(35,-2)"
+       gradientUnits="userSpaceOnUse"
+       y2="14.755193"
+       x2="30.5"
+       y1="14.755193"
+       x1="4.5"
+       id="linearGradient12547"
+       xlink:href="#linearGradient12537"
+       inkscape:collect="always" />
+    <linearGradient
+       inkscape:collect="always"
+       xlink:href="#linearGradient852"
+       id="linearGradient854"
+       x1="52.921474"
+       y1="21.254169"
+       x2="32.826744"
+       y2="-8.7244186"
+       gradientUnits="userSpaceOnUse" />
+    <linearGradient
+       inkscape:collect="always"
+       xlink:href="#linearGradient860"
+       id="linearGradient862"
+       x1="19.954786"
+       y1="-2.0214128"
+       x2="10.95193"
+       y2="-24.574963"
+       gradientUnits="userSpaceOnUse" />
+  </defs>
+  <sodipodi:namedview
+     inkscape:snap-grids="false"
+     inkscape:document-rotation="0"
+     inkscape:window-maximized="1"
+     inkscape:snap-global="true"
+     inkscape:window-y="-9"
+     inkscape:window-x="1791"
+     inkscape:window-height="1001"
+     inkscape:window-width="1920"
+     inkscape:document-units="px"
+     inkscape:grid-bbox="true"
+     showgrid="true"
+     inkscape:current-layer="layer1"
+     inkscape:cy="26.429049"
+     inkscape:cx="41.52997"
+     inkscape:zoom="7.6186209"
+     inkscape:pageshadow="2"
+     inkscape:pageopacity="0.0"
+     borderopacity="1.0"
+     bordercolor="#666666"
+     pagecolor="#ffffff"
+     id="base">
+    <inkscape:grid
+       originy="0"
+       originx="0"
+       spacingy="1"
+       spacingx="1"
+       snapvisiblegridlinesonly="true"
+       enabled="true"
+       visible="true"
+       empspacing="2"
+       units="px"
+       id="grid2989"
+       type="xygrid" />
+  </sodipodi:namedview>
+  <metadata
+     id="metadata9489">
+    <rdf:RDF>
+      <cc:Work
+         rdf:about="">
+        <dc:format>image/svg+xml</dc:format>
+        <dc:type
+           rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
+        <cc:license
+           rdf:resource="https://www.gnu.org/copyleft/lesser.html" />
+        <dc:title>Mesh_Fill_Up_Holes</dc:title>
+        <dc:description>Triangular mesh, and faces with holes</dc:description>
+        <dc:contributor>
+          <cc:Agent>
+            <dc:title>Icon based on a wmayer' s design</dc:title>
+          </cc:Agent>
+        </dc:contributor>
+        <dc:subject>
+          <rdf:Bag>
+            <rdf:li>mesh</rdf:li>
+            <rdf:li>triangles</rdf:li>
+            <rdf:li>faces</rdf:li>
+            <rdf:li>holes</rdf:li>
+          </rdf:Bag>
+        </dc:subject>
+        <dc:relation />
+        <dc:identifier />
+        <dc:publisher>
+          <cc:Agent>
+            <dc:title>FreeCAD</dc:title>
+          </cc:Agent>
+        </dc:publisher>
+        <dc:rights>
+          <cc:Agent>
+            <dc:title>FreeCAD LGPL2+</dc:title>
+          </cc:Agent>
+        </dc:rights>
+        <dc:date>11-06-2020</dc:date>
+        <dc:creator>
+          <cc:Agent>
+            <dc:title>[bitacovir]</dc:title>
+          </cc:Agent>
+        </dc:creator>
+      </cc:Work>
+    </rdf:RDF>
+  </metadata>
+  <g
+     style="opacity:1"
+     transform="translate(0,32)"
+     inkscape:groupmode="layer"
+     inkscape:label="Layer 1"
+     id="layer1">
+    <path
+       id="path849"
+       d="M 49.283683,-25.967157 5.4759648,-27.173726 5.0119,16.077115 Z"
+       style="fill:url(#linearGradient862);fill-opacity:1" />
+    <path
+       sodipodi:nodetypes="cccc"
+       inkscape:connector-curvature="0"
+       id="path2991-3"
+       d="m 8,18 43,-45 8,54 z"
+       style="fill:url(#linearGradient854);fill-opacity:1;stroke:none" />
+    <path
+       sodipodi:nodetypes="cccc"
+       inkscape:connector-curvature="0"
+       id="path2991"
+       d="m 4,19 47,-46 8,54 z"
+       style="fill:none;stroke:#172a04;stroke-width:3;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1" />
+    <path
+       id="path847"
+       d="M 4,19 5.4759648,-27.173726 51,-27"
+       style="fill:none;stroke:#172a04;stroke-width:3;stroke-linecap:butt;stroke-linejoin:round;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1" />
+    <ellipse
+       ry="5.4895983"
+       rx="6.7425733"
+       cy="8.1416073"
+       cx="38.51738"
+       id="path1032"
+       style="fill:#ffffff;stroke:#172a04;stroke-width:3;stroke-miterlimit:4;stroke-dasharray:none" />
+    <ellipse
+       style="opacity:1;fill:#ffffff;stroke:#172a04;stroke-width:3;stroke-miterlimit:4;stroke-dasharray:none"
+       id="path1032-8"
+       cx="19.212284"
+       cy="-14.087098"
+       rx="6.7425733"
+       ry="5.4895983" />
+    <path
+       style="fill:none;stroke:#8ae234;stroke-width:3;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
+       d="M 43.638983,-24.023232 8.3634608,-24.175561 7.2626144,11.59889 Z"
+       id="path864"
+       sodipodi:nodetypes="cccc" />
+    <path
+       style="fill:none;stroke:#8ae234;stroke-width:3;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
+       d="m 10.455051,16.868841 38.434178,-37.638473 6.543313,44.271784 z"
+       id="path866"
+       sodipodi:nodetypes="cccc" />
+  </g>
+</svg>