From a5b0be0b4cc3bc3eae070f90f3cd6bf00d1bd70d Mon Sep 17 00:00:00 2001
From: Bernd Hahnebach <bernd@bimstatik.org>
Date: Sun, 24 May 2020 09:19:27 +0200
Subject: [PATCH] FEM: add some comments to material and calculix solver object

---
 src/Mod/Fem/femobjects/material_common.py | 19 +++++++++++++++++++
 src/Mod/Fem/femsolver/calculix/solver.py  | 13 +++++++++++++
 2 files changed, 32 insertions(+)

diff --git a/src/Mod/Fem/femobjects/material_common.py b/src/Mod/Fem/femobjects/material_common.py
index f6796c3ecd..2aeeb6a3e8 100644
--- a/src/Mod/Fem/femobjects/material_common.py
+++ b/src/Mod/Fem/femobjects/material_common.py
@@ -67,3 +67,22 @@ class MaterialCommon(base_fempythonobject.BaseFemPythonObject):
             )
         obj.Category = ["Solid", "Fluid"]  # used in TaskPanel
         obj.Category = "Solid"
+        """
+        Some remarks to the category. Not finished, thus to be continued.
+
+        Following question need to be answered:
+        Why use a attribute to split the object? If a new fem object is needed,
+        a new fem object should be created. A new object will have an own Type
+        and will be collected for the writer by this type.
+
+        The category should not be used in writer! This would be the border.
+        If an fem object has to be distinguished in writer it should be an own
+        fem object.
+
+        The category is just some helper to make it easier for the user to
+        distinguish between different material categories.
+        It can have own command, own icon, own make method. In material TaskPanel
+        it can be distinguished which materials will be shown.
+
+        ATM in calculix writer the Category is used. See comments in CalculiX Solver.
+        """
diff --git a/src/Mod/Fem/femsolver/calculix/solver.py b/src/Mod/Fem/femsolver/calculix/solver.py
index 0ebeced6bc..2b2b9226a4 100644
--- a/src/Mod/Fem/femsolver/calculix/solver.py
+++ b/src/Mod/Fem/femsolver/calculix/solver.py
@@ -317,3 +317,16 @@ def add_attributes(obj, ccx_prefs):
     )
     dimout = ccx_prefs.GetBool("BeamShellOutput", False)
     obj.BeamShellResultOutput3D = dimout
+
+
+"""
+Should there be some equation object for Calculix too.
+
+Necessarily yes! The properties GeometricalNonlinearity,
+MaterialNonlinearity, ThermoMechSteadyState might be moved
+to the appropriate equation.
+
+Furthermore the material Category should not be used in writer.
+See common materila object for more information. The equation
+should used instead to get this information needed in writer.
+"""