kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Base: fix warnings from code analysers:

Browse Source 
* replace some C-style casts with static_cast
* remove unneeded destructors
* define default copy-constructor and assignment operator
This commit is contained in:
wmayer
2022-03-05 19:03:21 +01:00
parent 9de55d010c
commit a6624ef264
8 changed files with 34 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Base/ViewProj.h
View File

@@ -36,8 +36,11 @@ namespace Base {
class BaseExport ViewProjMethod
{
public:
virtual ~ViewProjMethod(){}
virtual bool isValid() const { return true; }
ViewProjMethod(const ViewProjMethod&) = default;
ViewProjMethod& operator= (const ViewProjMethod&) = default;
virtual ~ViewProjMethod() = default;
virtual bool isValid() const;
/** Convert 3D point to 2D projection plane */
virtual Vector3f operator()(const Vector3f &rclPt) const = 0;
/** Convert 3D point to 2D projection plane */
@@ -74,7 +77,6 @@ class BaseExport ViewProjMatrix : public ViewProjMethod
{
public:
ViewProjMatrix (const Matrix4D &rclMtx);
virtual ~ViewProjMatrix();
Vector3f operator()(const Vector3f &rclPt) const;
Vector3d operator()(const Vector3d &rclPt) const;
@@ -98,7 +100,6 @@ class BaseExport ViewOrthoProjMatrix : public ViewProjMethod
{
public:
ViewOrthoProjMatrix (const Matrix4D &rclMtx);
virtual ~ViewOrthoProjMatrix();
Vector3f operator()(const Vector3f &rclPt) const;
Vector3d operator()(const Vector3d &rclPt) const;