From a6c6344c6b86d3b667fec9a27838461cac569b62 Mon Sep 17 00:00:00 2001 From: Uwe Date: Thu, 6 Oct 2022 02:36:48 +0200 Subject: [PATCH] [TD] P* - T*: remove unused includes - also sort includes - also additions to precompiled header --- src/Mod/Part/App/OpenCascadeAll.h | 1 + src/Mod/TechDraw/App/Preferences.cpp | 3 +- src/Mod/TechDraw/App/Preferences.h | 3 +- src/Mod/TechDraw/App/ProjectionAlgos.cpp | 62 +++----------- src/Mod/TechDraw/App/ProjectionAlgos.h | 11 ++- .../TechDraw/App/PropertyCenterLineList.cpp | 25 ++---- .../TechDraw/App/PropertyCosmeticEdgeList.cpp | 25 ++---- .../App/PropertyCosmeticVertexList.cpp | 25 ++---- .../TechDraw/App/PropertyGeomFormatList.cpp | 25 ++---- src/Mod/TechDraw/App/QDomNodeModel.cpp | 10 +-- src/Mod/TechDraw/App/QDomNodeModel.h | 4 +- src/Mod/TechDraw/App/ShapeExtractor.cpp | 27 ++---- src/Mod/TechDraw/App/ShapeExtractor.h | 4 +- src/Mod/TechDraw/App/TechDrawExport.cpp | 82 +++++++------------ src/Mod/TechDraw/App/TechDrawExport.h | 6 +- 15 files changed, 99 insertions(+), 214 deletions(-) diff --git a/src/Mod/Part/App/OpenCascadeAll.h b/src/Mod/Part/App/OpenCascadeAll.h index 22117ee72e..a5d2c106ec 100644 --- a/src/Mod/Part/App/OpenCascadeAll.h +++ b/src/Mod/Part/App/OpenCascadeAll.h @@ -356,6 +356,7 @@ // HLR* #include #include +#include #include #include #include diff --git a/src/Mod/TechDraw/App/Preferences.cpp b/src/Mod/TechDraw/App/Preferences.cpp index 3c13ad009d..59b87dbd80 100644 --- a/src/Mod/TechDraw/App/Preferences.cpp +++ b/src/Mod/TechDraw/App/Preferences.cpp @@ -30,13 +30,12 @@ #include #include #include -#include #include #include -#include #include "Preferences.h" + //getters for parameters used in multiple places. //ensure this is in sync with preference page user interfaces diff --git a/src/Mod/TechDraw/App/Preferences.h b/src/Mod/TechDraw/App/Preferences.h index 0f6c89c8a9..aaafd5fa5e 100644 --- a/src/Mod/TechDraw/App/Preferences.h +++ b/src/Mod/TechDraw/App/Preferences.h @@ -23,11 +23,10 @@ #ifndef Preferences_h_ #define Preferences_h_ -#include +#include #include -#include class QString; diff --git a/src/Mod/TechDraw/App/ProjectionAlgos.cpp b/src/Mod/TechDraw/App/ProjectionAlgos.cpp index 9a46a4178e..2a6842dc86 100644 --- a/src/Mod/TechDraw/App/ProjectionAlgos.cpp +++ b/src/Mod/TechDraw/App/ProjectionAlgos.cpp @@ -22,62 +22,27 @@ //this file originally part of TechDraw workbench //migrated to TechDraw workbench 2022-01-26 by Wandererfan - #include "PreCompiled.h" #ifndef _PreComp_ # include -# include -# include -# include -# include +# include +# include +# include +# include +# include +# include +# include +# include +# include +# include +# include #endif -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#include -#include -#include -#include - #include "ProjectionAlgos.h" #include "TechDrawExport.h" + using namespace TechDraw; using namespace std; @@ -86,7 +51,6 @@ using namespace std; //=========================================================================== - ProjectionAlgos::ProjectionAlgos(const TopoDS_Shape &Input, const Base::Vector3d &Dir) : Input(Input), Direction(Dir) { @@ -113,7 +77,7 @@ void ProjectionAlgos::execute() Handle( HLRBRep_Algo ) brep_hlr = new HLRBRep_Algo; brep_hlr->Add(Input); - gp_Ax2 transform(gp_Pnt(0, 0,0), gp_Dir(Direction.x, Direction.y, Direction.z)); + gp_Ax2 transform(gp_Pnt(0, 0, 0), gp_Dir(Direction.x, Direction.y, Direction.z)); HLRAlgo_Projector projector( transform ); brep_hlr->Projector(projector); brep_hlr->Update(); diff --git a/src/Mod/TechDraw/App/ProjectionAlgos.h b/src/Mod/TechDraw/App/ProjectionAlgos.h index 71e5a0e61e..f4e8199fe1 100644 --- a/src/Mod/TechDraw/App/ProjectionAlgos.h +++ b/src/Mod/TechDraw/App/ProjectionAlgos.h @@ -22,17 +22,16 @@ //this file originally part of Drawing workbench //migrated to TechDraw workbench 2022-01-26 by Wandererfan - #ifndef TechDrawProjectionAlgos_h_ #define TechDrawProjectionAlgos_h_ +#include +#include +#include + +#include #include -#include - -#include -#include -#include class BRepAdaptor_Curve; diff --git a/src/Mod/TechDraw/App/PropertyCenterLineList.cpp b/src/Mod/TechDraw/App/PropertyCenterLineList.cpp index b236bd22e2..7d635dfe68 100644 --- a/src/Mod/TechDraw/App/PropertyCenterLineList.cpp +++ b/src/Mod/TechDraw/App/PropertyCenterLineList.cpp @@ -20,32 +20,20 @@ * * ***************************************************************************/ - #include "PreCompiled.h" -#ifndef _PreComp_ -# include -#endif - -/// Here the FreeCAD includes sorted by Base, App, Gui...... - -#include +#include #include #include -#include - -#include "Cosmetic.h" -#include "CenterLinePy.h" #include "PropertyCenterLineList.h" +#include "CenterLinePy.h" using namespace App; using namespace Base; -using namespace std; using namespace TechDraw; - //************************************************************************** // PropertyCenterLineList //++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ @@ -137,18 +125,19 @@ void PropertyCenterLineList::setPyObject(PyObject *value) void PropertyCenterLineList::Save(Writer &writer) const { - writer.Stream() << writer.ind() << "" << endl; + writer.Stream() << writer.ind() << "" + << std::endl; writer.incInd(); for (int i = 0; i < getSize(); i++) { writer.Stream() << writer.ind() << "getTypeId().getName() << "\">" << endl; + << _lValueList[i]->getTypeId().getName() << "\">" << std::endl; writer.incInd(); _lValueList[i]->Save(writer); writer.decInd(); - writer.Stream() << writer.ind() << "" << endl; + writer.Stream() << writer.ind() << "" << std::endl; } writer.decInd(); - writer.Stream() << writer.ind() << "" << endl ; + writer.Stream() << writer.ind() << "" << std::endl; } void PropertyCenterLineList::Restore(Base::XMLReader &reader) diff --git a/src/Mod/TechDraw/App/PropertyCosmeticEdgeList.cpp b/src/Mod/TechDraw/App/PropertyCosmeticEdgeList.cpp index 48516b0fc0..af3af4b7a5 100644 --- a/src/Mod/TechDraw/App/PropertyCosmeticEdgeList.cpp +++ b/src/Mod/TechDraw/App/PropertyCosmeticEdgeList.cpp @@ -20,32 +20,20 @@ * * ***************************************************************************/ - #include "PreCompiled.h" -#ifndef _PreComp_ -# include -#endif - -/// Here the FreeCAD includes sorted by Base, App, Gui...... - -#include +#include #include #include -#include - -#include "Cosmetic.h" -#include "CosmeticEdgePy.h" #include "PropertyCosmeticEdgeList.h" +#include "CosmeticEdgePy.h" using namespace App; using namespace Base; -using namespace std; using namespace TechDraw; - //************************************************************************** // PropertyCosmeticEdgeList //++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ @@ -139,18 +127,19 @@ void PropertyCosmeticEdgeList::setPyObject(PyObject *value) void PropertyCosmeticEdgeList::Save(Writer &writer) const { - writer.Stream() << writer.ind() << "" << endl; + writer.Stream() << writer.ind() << "" + << std::endl; writer.incInd(); for (int i = 0; i < getSize(); i++) { writer.Stream() << writer.ind() << "getTypeId().getName() << "\">" << endl; + << _lValueList[i]->getTypeId().getName() << "\">" << std::endl; writer.incInd(); _lValueList[i]->Save(writer); writer.decInd(); - writer.Stream() << writer.ind() << "" << endl; + writer.Stream() << writer.ind() << "" << std::endl; } writer.decInd(); - writer.Stream() << writer.ind() << "" << endl ; + writer.Stream() << writer.ind() << "" << std::endl; } void PropertyCosmeticEdgeList::Restore(Base::XMLReader &reader) diff --git a/src/Mod/TechDraw/App/PropertyCosmeticVertexList.cpp b/src/Mod/TechDraw/App/PropertyCosmeticVertexList.cpp index bf2be8a3d6..ced5eb181e 100644 --- a/src/Mod/TechDraw/App/PropertyCosmeticVertexList.cpp +++ b/src/Mod/TechDraw/App/PropertyCosmeticVertexList.cpp @@ -20,32 +20,20 @@ * * ***************************************************************************/ - #include "PreCompiled.h" -#ifndef _PreComp_ -# include -#endif - -/// Here the FreeCAD includes sorted by Base, App, Gui...... - -#include +#include #include #include -#include - -#include "Cosmetic.h" -#include "CosmeticVertexPy.h" #include "PropertyCosmeticVertexList.h" +#include "CosmeticVertexPy.h" using namespace App; using namespace Base; -using namespace std; using namespace TechDraw; - //************************************************************************** // PropertyCosmeticVertexList //++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ @@ -139,18 +127,19 @@ void PropertyCosmeticVertexList::setPyObject(PyObject *value) void PropertyCosmeticVertexList::Save(Writer &writer) const { - writer.Stream() << writer.ind() << "" << endl; + writer.Stream() << writer.ind() << "" + << std::endl; writer.incInd(); for (int i = 0; i < getSize(); i++) { writer.Stream() << writer.ind() << "getTypeId().getName() << "\">" << endl; + << _lValueList[i]->getTypeId().getName() << "\">" << std::endl; writer.incInd(); _lValueList[i]->Save(writer); writer.decInd(); - writer.Stream() << writer.ind() << "" << endl; + writer.Stream() << writer.ind() << "" << std::endl; } writer.decInd(); - writer.Stream() << writer.ind() << "" << endl ; + writer.Stream() << writer.ind() << "" << std::endl; } void PropertyCosmeticVertexList::Restore(Base::XMLReader &reader) diff --git a/src/Mod/TechDraw/App/PropertyGeomFormatList.cpp b/src/Mod/TechDraw/App/PropertyGeomFormatList.cpp index ce1e6f15ba..fca52e0258 100644 --- a/src/Mod/TechDraw/App/PropertyGeomFormatList.cpp +++ b/src/Mod/TechDraw/App/PropertyGeomFormatList.cpp @@ -20,32 +20,20 @@ * * ***************************************************************************/ - #include "PreCompiled.h" -#ifndef _PreComp_ -# include -#endif - -/// Here the FreeCAD includes sorted by Base, App, Gui...... - -#include +#include #include #include -#include - -#include "Cosmetic.h" -#include "GeomFormatPy.h" #include "PropertyGeomFormatList.h" +#include "GeomFormatPy.h" using namespace App; using namespace Base; -using namespace std; using namespace TechDraw; - //************************************************************************** // PropertyGeomFormatList //++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ @@ -151,18 +139,19 @@ void PropertyGeomFormatList::setPyObject(PyObject *value) void PropertyGeomFormatList::Save(Writer &writer) const { - writer.Stream() << writer.ind() << "" << endl; + writer.Stream() << writer.ind() << "" + << std::endl; writer.incInd(); for (int i = 0; i < getSize(); i++) { writer.Stream() << writer.ind() << "getTypeId().getName() << "\">" << endl; + << _lValueList[i]->getTypeId().getName() << "\">" << std::endl; writer.incInd(); _lValueList[i]->Save(writer); writer.decInd(); - writer.Stream() << writer.ind() << "" << endl; + writer.Stream() << writer.ind() << "" << std::endl; } writer.decInd(); - writer.Stream() << writer.ind() << "" << endl ; + writer.Stream() << writer.ind() << "" << std::endl; } void PropertyGeomFormatList::Restore(Base::XMLReader &reader) diff --git a/src/Mod/TechDraw/App/QDomNodeModel.cpp b/src/Mod/TechDraw/App/QDomNodeModel.cpp index e6add21af7..901aeadb40 100644 --- a/src/Mod/TechDraw/App/QDomNodeModel.cpp +++ b/src/Mod/TechDraw/App/QDomNodeModel.cpp @@ -26,14 +26,14 @@ #include "PreCompiled.h" -#include "QDomNodeModel.h" - -#include #include -#include -#include +#include +#include "QDomNodeModel.h" #include +#include #include +#include + class PrivateDomNodeWrapper: public QDomNode { diff --git a/src/Mod/TechDraw/App/QDomNodeModel.h b/src/Mod/TechDraw/App/QDomNodeModel.h index daaa4c5581..de1d55b94e 100644 --- a/src/Mod/TechDraw/App/QDomNodeModel.h +++ b/src/Mod/TechDraw/App/QDomNodeModel.h @@ -26,8 +26,8 @@ #ifndef QDOMNODEMODEL_H_ #define QDOMNODEMODEL_H_ - -#include + +#include #include #include diff --git a/src/Mod/TechDraw/App/ShapeExtractor.cpp b/src/Mod/TechDraw/App/ShapeExtractor.cpp index 524e45010a..e663caefd2 100644 --- a/src/Mod/TechDraw/App/ShapeExtractor.cpp +++ b/src/Mod/TechDraw/App/ShapeExtractor.cpp @@ -24,40 +24,29 @@ #ifndef _PreComp_ # include +# include +# include +# include +# include +# include +# include #endif -#include -#include -#include -#include -#include -#include -#include -#include -#include - #include #include #include -#include #include - -#include +#include #include -#include -#include #include #include - #include #include -#include -#include -#include #include "ShapeExtractor.h" #include "DrawUtil.h" + using namespace TechDraw; std::vector ShapeExtractor::getShapes2d(const std::vector links) diff --git a/src/Mod/TechDraw/App/ShapeExtractor.h b/src/Mod/TechDraw/App/ShapeExtractor.h index 2d30930cb0..994a6d80f7 100644 --- a/src/Mod/TechDraw/App/ShapeExtractor.h +++ b/src/Mod/TechDraw/App/ShapeExtractor.h @@ -23,8 +23,6 @@ #ifndef ShapeExtractor_h_ #define ShapeExtractor_h_ -#include - #include #include @@ -32,6 +30,8 @@ #include #include +#include + namespace TechDraw { diff --git a/src/Mod/TechDraw/App/TechDrawExport.cpp b/src/Mod/TechDraw/App/TechDrawExport.cpp index 6083ceb823..4ceeda2656 100644 --- a/src/Mod/TechDraw/App/TechDrawExport.cpp +++ b/src/Mod/TechDraw/App/TechDrawExport.cpp @@ -22,65 +22,43 @@ //this file originally part of TechDraw workbench //migrated to TechDraw workbench 2022-01-26 by Wandererfan - #include "PreCompiled.h" #ifndef _PreComp_ -# include # include +# include +# include +# include # include -# include +# include +# include +# include +# include +# include +# include +# include +# include # include # include +# include +# include +# include +# include +# include +# include +# include +# include +# include +# include +# if OCC_VERSION_HEX < 0x070600 +# include +# endif #endif -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#if OCC_VERSION_HEX < 0x070600 -#include -#endif +#include #include "TechDrawExport.h" -#include -#include + #if OCC_VERSION_HEX >= 0x070600 using BRepAdaptor_HCurve = BRepAdaptor_Curve; @@ -242,7 +220,7 @@ void SVGOutput::printCircle(const BRepAdaptor_Curve& c, std::ostream& out) else { // See also https://developer.mozilla.org/en/SVG/Tutorial/Paths char xar = '0'; // x-axis-rotation - char las = (l-f > D_PI) ? '1' : '0'; // large-arc-flag + char las = (l-f > M_PI) ? '1' : '0'; // large-arc-flag char swp = (a < 0) ? '1' : '0'; // sweep-flag, i.e. clockwise (0) or counter-clockwise (1) out << " D_PI) ? '1' : '0'; // large-arc-flag + char las = (l-f > M_PI) ? '1' : '0'; // large-arc-flag char swp = (a < 0) ? '1' : '0'; // sweep-flag, i.e. clockwise (0) or counter-clockwise (1) out << " 0){ diff --git a/src/Mod/TechDraw/App/TechDrawExport.h b/src/Mod/TechDraw/App/TechDrawExport.h index 87c28b2089..e965637c1b 100644 --- a/src/Mod/TechDraw/App/TechDrawExport.h +++ b/src/Mod/TechDraw/App/TechDrawExport.h @@ -22,15 +22,15 @@ //this file originally part of Drawing workbench //migrated to TechDraw workbench 2022-01-26 by Wandererfan - #ifndef TECHDRAW_EXPORT_H #define TECHDRAW_EXPORT_H -#include - #include #include +#include + + class TopoDS_Shape; class BRepAdaptor_Curve;