diff --git a/src/Mod/Draft/DraftGui.py b/src/Mod/Draft/DraftGui.py index 0b34c1ad1e..4c9303c61a 100644 --- a/src/Mod/Draft/DraftGui.py +++ b/src/Mod/Draft/DraftGui.py @@ -1743,7 +1743,7 @@ class DraftToolBar: c = self.panel.form.findChild(QtGui.QCheckBox,"ContinueCmd") if c: c.toggle() - except: + except Exception: pass def isConstructionMode(self): diff --git a/src/Mod/Draft/draftfunctions/dxf.py b/src/Mod/Draft/draftfunctions/dxf.py index df009377fa..ccd365435c 100644 --- a/src/Mod/Draft/draftfunctions/dxf.py +++ b/src/Mod/Draft/draftfunctions/dxf.py @@ -120,7 +120,7 @@ def get_dxf(obj, direction=None): try: d = Drawing.projectToDXF(obj.Shape, direction) - except: + except Exception: # TODO: trap only specific exception. # Impossible to generate DXF from Shape? Which exception is throw? _wrn("get_dxf: " diff --git a/src/Mod/Draft/draftfunctions/svg.py b/src/Mod/Draft/draftfunctions/svg.py index d973e0ea28..7005b334ea 100644 --- a/src/Mod/Draft/draftfunctions/svg.py +++ b/src/Mod/Draft/draftfunctions/svg.py @@ -75,7 +75,7 @@ def get_line_style(line_style, scale): # scale dashes style = ",".join([str(float(d)/scale) for d in style]) # print("lstyle ", style) - except: + except Exception: # TODO: trap only specific exception; what is the problem? # Bad string specification? return "none" diff --git a/src/Mod/Draft/draftfunctions/svgtext.py b/src/Mod/Draft/draftfunctions/svgtext.py index cb0d775d64..0a32bb994c 100644 --- a/src/Mod/Draft/draftfunctions/svgtext.py +++ b/src/Mod/Draft/draftfunctions/svgtext.py @@ -183,7 +183,7 @@ def get_text(plane, techdraw, try: _t = text[0].replace("&", "&").replace("<", "<") svg += _t.replace(">", ">") - except: + except Exception: # TODO: trap only specific exception; what is the problem? # Bad UTF8 string specification? This can be removed # once the code is only used with Python 3. @@ -200,7 +200,7 @@ def get_text(plane, techdraw, try: _t = text[i].replace("&", "&").replace("<", "<") svg += _t.replace(">", ">") - except: + except Exception: # TODO: trap only specific exception; what is the problem? # Bad UTF8 string specification? This can be removed # once the code is only used with Python 3. diff --git a/src/Mod/Draft/draftguitools/gui_annotationstyleeditor.py b/src/Mod/Draft/draftguitools/gui_annotationstyleeditor.py index 82be6d8539..f7fa02ef8d 100644 --- a/src/Mod/Draft/draftguitools/gui_annotationstyleeditor.py +++ b/src/Mod/Draft/draftguitools/gui_annotationstyleeditor.py @@ -201,10 +201,10 @@ class AnnotationStyleEditor(gui_base.GuiCommandSimplest): if hasattr(vobj, attr): try: getattr(vobj,attr).setValue(attrvalue) - except: + except Exception: try: setattr(vobj,attr,attrvalue) - except: + except Exception: unitvalue = U.Quantity(attrvalue, U.Length).Value setattr(vobj,attr,unitvalue) else: diff --git a/src/Mod/Draft/draftguitools/gui_edit.py b/src/Mod/Draft/draftguitools/gui_edit.py index 722e90cec7..5533e0da9a 100644 --- a/src/Mod/Draft/draftguitools/gui_edit.py +++ b/src/Mod/Draft/draftguitools/gui_edit.py @@ -669,7 +669,7 @@ class Edit(gui_base_original.Modifier): self.current_editing_object_gui_tools = None self.ghost.finalize() self.ghost = None - except: + except Exception: return # ------------------------------------------------------------------------- @@ -914,7 +914,7 @@ class Edit(gui_base_original.Modifier): except AttributeError: try: obj_gui_tools = self.gui_tools_repository.get(utils.get_type(obj)) - except: + except Exception: obj_gui_tools = None return obj_gui_tools diff --git a/src/Mod/Draft/draftguitools/gui_edit_arch_objects.py b/src/Mod/Draft/draftguitools/gui_edit_arch_objects.py index 8c6cd28f3c..7986f06c1c 100644 --- a/src/Mod/Draft/draftguitools/gui_edit_arch_objects.py +++ b/src/Mod/Draft/draftguitools/gui_edit_arch_objects.py @@ -170,7 +170,7 @@ class ArchSpaceGuiTools(GuiTools): editpoints = [] editpoints.append(obj.ViewObject.Proxy.getTextPosition(obj.ViewObject)) return editpoints - except: + except Exception: pass def update_object_from_edit_points(self, obj, node_idx, v, alt_edit_mode=0): diff --git a/src/Mod/Draft/draftguitools/gui_setstyle.py b/src/Mod/Draft/draftguitools/gui_setstyle.py index 5dcd6a923c..75702c6ca0 100644 --- a/src/Mod/Draft/draftguitools/gui_setstyle.py +++ b/src/Mod/Draft/draftguitools/gui_setstyle.py @@ -132,7 +132,7 @@ class Draft_SetStyle_TaskPanel: if dm in dmodes: try: vobj.DisplayMode = dm - except: + except Exception: pass if "ShapeColor" in vobj.PropertiesList: vobj.ShapeColor = self.form.ShapeColor.property("color").rgb()<<8 diff --git a/src/Mod/Draft/draftguitools/gui_snapper.py b/src/Mod/Draft/draftguitools/gui_snapper.py index bd880e6030..7f47e17c8a 100644 --- a/src/Mod/Draft/draftguitools/gui_snapper.py +++ b/src/Mod/Draft/draftguitools/gui_snapper.py @@ -1018,7 +1018,7 @@ class Snapper: if pt: for p in pt: snaps.append([p, 'intersection', self.toWP(p)]) - except: + except Exception: pass # some curve types yield an error # when trying to read their types diff --git a/src/Mod/Draft/draftguitools/gui_trackers.py b/src/Mod/Draft/draftguitools/gui_trackers.py index 47c22adb11..2756a6786c 100644 --- a/src/Mod/Draft/draftguitools/gui_trackers.py +++ b/src/Mod/Draft/draftguitools/gui_trackers.py @@ -1110,7 +1110,7 @@ class gridTracker(Tracker): try: import BimProject hpts = BimProject.getHuman(loc) - except: + except Exception: # BIM not installed pass else: diff --git a/src/Mod/Draft/draftmake/make_clone.py b/src/Mod/Draft/draftmake/make_clone.py index 76e1f3de35..4a4b57402f 100644 --- a/src/Mod/Draft/draftmake/make_clone.py +++ b/src/Mod/Draft/draftmake/make_clone.py @@ -80,7 +80,7 @@ def make_clone(obj, delta=None, forcedraft=False): else: try: clonefunc = getattr(Arch,"make"+obj[0].Proxy.Type) - except: + except Exception: pass # not a standard Arch object... Fall back to Draft mode else: cl = clonefunc() @@ -96,7 +96,7 @@ def make_clone(obj, delta=None, forcedraft=False): cl.Role = base.Role cl.Description = base.Description cl.Tag = base.Tag - except: + except Exception: pass if App.GuiUp: gui_utils.format_object(cl,base) diff --git a/src/Mod/Draft/draftobjects/clone.py b/src/Mod/Draft/draftobjects/clone.py index 2ea79952e4..e89c0f0ce5 100644 --- a/src/Mod/Draft/draftobjects/clone.py +++ b/src/Mod/Draft/draftobjects/clone.py @@ -79,7 +79,7 @@ class Clone(DraftObject): try: sh = shapes[0].multiFuse(shapes[1:]) sh = sh.removeSplitter() - except: + except Exception: pass else: return sh diff --git a/src/Mod/Draft/draftobjects/patharray.py b/src/Mod/Draft/draftobjects/patharray.py index fe7c0355a5..7b134872a3 100644 --- a/src/Mod/Draft/draftobjects/patharray.py +++ b/src/Mod/Draft/draftobjects/patharray.py @@ -546,7 +546,7 @@ def calculate_placement(globalRotation, try: t = edge.tangentAt(get_parameter_from_v0(edge, offset)) t.normalize() - except: + except Exception: _wrn(_tr("Cannot calculate path tangent. Copy not aligned.")) return placement @@ -560,7 +560,7 @@ def calculate_placement(globalRotation, try: b = t.cross(n) b.normalize() - except: + except Exception: # weird special case, tangent and normal parallel b = nullv _wrn(_tr("Tangent and normal are parallel. Copy not aligned.")) @@ -585,7 +585,7 @@ def calculate_placement(globalRotation, try: b = t.cross(n) b.normalize() - except: + except Exception: b = nullv _wrn(_tr("Cannot calculate path binormal. Copy not aligned.")) return placement diff --git a/src/Mod/Draft/draftobjects/shapestring.py b/src/Mod/Draft/draftobjects/shapestring.py index 022e055fe6..bcbdcb1c66 100644 --- a/src/Mod/Draft/draftobjects/shapestring.py +++ b/src/Mod/Draft/draftobjects/shapestring.py @@ -150,7 +150,7 @@ class ShapeString(DraftObject): # some fonts fail here if face.Surface.Axis.z < 0.0: face.reverse() - except: + except Exception: pass compFaces.append(face) ret = Part.Compound(compFaces) diff --git a/src/Mod/Draft/draftutils/init_draft_statusbar.py b/src/Mod/Draft/draftutils/init_draft_statusbar.py index 02dead1a71..1c0c1c07d9 100644 --- a/src/Mod/Draft/draftutils/init_draft_statusbar.py +++ b/src/Mod/Draft/draftutils/init_draft_statusbar.py @@ -113,7 +113,7 @@ def label_to_scale(label): try : scale = float(label) return scale - except : + except Exception: if ":" in label: f = label.split(":") elif "=" in label: @@ -126,7 +126,7 @@ def label_to_scale(label): den = App.Units.Quantity(f[1]).Value scale = num/den return scale - except: + except Exception: err = QT_TRANSLATE_NOOP("draft", "Unable to convert input into a " "scale factor") diff --git a/src/Mod/Draft/importDXF.py b/src/Mod/Draft/importDXF.py index fac0493aa3..dfe72e4678 100644 --- a/src/Mod/Draft/importDXF.py +++ b/src/Mod/Draft/importDXF.py @@ -184,7 +184,7 @@ def getDXFlibs(): import dxfColorMap try: import dxfReader - except: + except Exception: libsok = False except ImportError: libsok = False @@ -2045,10 +2045,10 @@ def addText(text, attrib=False): # better store as utf8 always. # try: # val = val.decode("utf8").encode("Latin1") - # except: + # except Exception: # try: # val = val.encode("latin1") - # except: + # except Exception: # pass newob = Draft.makeText(val.split("\n")) if hasattr(lay, "addObject"): @@ -3537,7 +3537,7 @@ def getStr(l): # dxf R12 files are rather over-sensitive with utf8... try: import unicodedata - except: + except Exception: # fallback return l.encode("ascii", errors="replace") else: