PD: [skip ci] Fix several clazy issues:

* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
* Unused QByteArray [-Wclazy-unused-non-trivial-variable]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
This commit is contained in:
wmayer
2022-07-25 13:40:19 +02:00
parent 50ef527ded
commit a93082bc06
19 changed files with 83 additions and 83 deletions

View File

@@ -60,7 +60,7 @@ short DressUp::mustExecute() const
{
if (Base.getValue() && Base.getValue()->isTouched())
return 1;
return PartDesign::Feature::mustExecute();
return PartDesign::FeatureAddSub::mustExecute();
}
void DressUp::positionByBaseFeature(void)

View File

@@ -236,7 +236,7 @@ App::DocumentObjectExecReturn *Transformed::execute(void)
shapes.emplace_back(shape);
}
for (auto shape : shapes)
for (const auto& shape : shapes)
shapeTools.Append(shape);
return shapeTools;

View File

@@ -204,7 +204,7 @@ Part::TopoShape ShapeBinder::buildShapeFromReferences(App::GeoFeature* obj, std:
return part->Shape.getValue();
std::vector<TopoDS_Shape> shapes;
for (std::string sub : subs) {
for (const std::string& sub : subs) {
shapes.push_back(part->Shape.getShape().getSubShape(sub.c_str()));
}