kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PD: [skip ci] Fix several clazy issues:

Browse Source 
* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
* Unused QByteArray [-Wclazy-unused-non-trivial-variable]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
This commit is contained in:
wmayer
2022-07-25 13:40:19 +02:00
parent 50ef527ded
commit a93082bc06
19 changed files with 83 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/PartDesign/Gui/TaskLoftParameters.cpp
View File

@@ -85,7 +85,8 @@ TaskLoftParameters::TaskLoftParameters(ViewProviderLoft *LoftView, bool /*newObj
this->groupLayout()->addWidget(proxy);
// Temporarily prevent unnecessary feature recomputes
for (QWidget* child : proxy->findChildren<QWidget*>())
const auto childs = proxy->findChildren<QWidget*>();
for (QWidget* child : childs)
child->blockSignals(true);
//add the profiles
@@ -115,7 +116,7 @@ TaskLoftParameters::TaskLoftParameters(ViewProviderLoft *LoftView, bool /*newObj
ui->checkBoxClosed->setChecked(loft->Closed.getValue());
// activate and de-activate dialog elements as appropriate
for (QWidget* child : proxy->findChildren<QWidget*>())
for (QWidget* child : childs)
child->blockSignals(false);
updateUI();
@@ -225,7 +226,7 @@ void TaskLoftParameters::removeFromListWidget(QListWidget* widget, QString name)
QList<QListWidgetItem*> items = widget->findItems(name, Qt::MatchExactly);
if (!items.empty()) {
for (QList<QListWidgetItem*>::const_iterator it = items.begin(); it != items.end(); ++it) {
for (QList<QListWidgetItem*>::const_iterator it = items.cbegin(); it != items.cend(); ++it) {
QListWidgetItem* item = widget->takeItem(widget->row(*it));
delete item;
}
@@ -266,7 +267,6 @@ void TaskLoftParameters::indexesMoved()
PartDesign::Loft* loft = static_cast<PartDesign::Loft*>(vp->getObject());
auto originals = loft->Sections.getSubListValues();
QByteArray name;
int rows = model->rowCount();
for (int i = 0; i < rows; i++) {
QModelIndex index = model->index(i, 0);